From: "Cédric Le Goater" <clg@kaod.org>
To: "Víctor Colombo" <victor.colombo@eldorado.org.br>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
Greg Kurz <groug@kaod.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] target/ppc: Remove support for the PowerPC 602 CPU
Date: Fri, 28 Jan 2022 21:28:29 +0100 [thread overview]
Message-ID: <cb0d7e80-aee2-9eb3-0ac4-8cec07032a96@kaod.org> (raw)
In-Reply-To: <48832eff-fc37-86f6-842c-43b75fbe83be@eldorado.org.br>
On 1/28/22 15:13, Víctor Colombo wrote:
> On 28/01/2022 10:12, Cédric Le Goater wrote:
>> The 602 was derived from the PowerPC 603, for the gaming market it
>> seems. It was hardly used and no firmware supporting the CPU could be
>> found. Drop support.
>>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>
> Hello Cédric! I am having problems building QEMU with this patch
> applied. Tried on both master and legoater/ppc-7.0. I think you forgot
> one reference to PPC_602_SPEC on cpu.h:
>
> #define PPC_TCG_INSNS (PPC_INSNS_BASE | PPC_POWER | PPC_POWER2 \
> | PPC_POWER_RTC | PPC_POWER_BR | PPC_64B \
> | PPC_64BX | PPC_64H | PPC_WAIT | PPC_MFTB \
> - | PPC_602_SPEC | PPC_ISEL | PPC_POPCNTB \
> + | PPC_ISEL | PPC_POPCNTB \
> | PPC_STRING | PPC_FLOAT | PPC_FLOAT_EXT \
> | PPC_FLOAT_FSQRT | PPC_FLOAT_FRES \
> | PPC_FLOAT_FRSQRTE | PPC_FLOAT_FRSQRTES \
>
>
> Could you take a look at it please? Thanks!
Yes :/ Thanks for checking.
C.
next prev parent reply other threads:[~2022-01-28 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 13:12 [PATCH] target/ppc: Remove support for the PowerPC 602 CPU Cédric Le Goater
2022-01-28 14:13 ` Víctor Colombo
2022-01-28 20:28 ` Cédric Le Goater [this message]
2022-01-28 14:29 ` Fabiano Rosas
2022-01-28 20:51 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb0d7e80-aee2-9eb3-0ac4-8cec07032a96@kaod.org \
--to=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=victor.colombo@eldorado.org.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).