* [Qemu-devel] [PATCH] migration/block-dirty-bitmap: fix dirty_bitmap_load
@ 2018-05-30 11:24 Vladimir Sementsov-Ogievskiy
2018-05-30 15:22 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2018-05-30 11:24 UTC (permalink / raw)
To: qemu-devel, qemu-block
Cc: dgilbert, quintela, famz, stefanha, vsementsov, den, jsnow,
qemu-stable, eblake
dirty_bitmap_load_header return code is obtained but not handled. Fix
this.
Bug was introduced in b35ebdf076d697bc
"migration: add postcopy migration of dirty bitmaps" with the whole
function.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
migration/block-dirty-bitmap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
index 8819aabe3a..2c541c985d 100644
--- a/migration/block-dirty-bitmap.c
+++ b/migration/block-dirty-bitmap.c
@@ -672,6 +672,9 @@ static int dirty_bitmap_load(QEMUFile *f, void *opaque, int version_id)
do {
ret = dirty_bitmap_load_header(f, &s);
+ if (ret < 0) {
+ return ret;
+ }
if (s.flags & DIRTY_BITMAP_MIG_FLAG_START) {
ret = dirty_bitmap_load_start(f, &s);
--
2.11.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: fix dirty_bitmap_load
2018-05-30 11:24 [Qemu-devel] [PATCH] migration/block-dirty-bitmap: fix dirty_bitmap_load Vladimir Sementsov-Ogievskiy
@ 2018-05-30 15:22 ` Eric Blake
2018-05-30 20:25 ` John Snow
2018-06-15 11:24 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2018-05-30 15:22 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy, qemu-devel, qemu-block
Cc: dgilbert, quintela, famz, stefanha, den, jsnow, qemu-stable
On 05/30/2018 06:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> dirty_bitmap_load_header return code is obtained but not handled. Fix
> this.
>
> Bug was introduced in b35ebdf076d697bc
> "migration: add postcopy migration of dirty bitmaps" with the whole
> function.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> migration/block-dirty-bitmap.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: fix dirty_bitmap_load
2018-05-30 11:24 [Qemu-devel] [PATCH] migration/block-dirty-bitmap: fix dirty_bitmap_load Vladimir Sementsov-Ogievskiy
2018-05-30 15:22 ` Eric Blake
@ 2018-05-30 20:25 ` John Snow
2018-06-15 11:24 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: John Snow @ 2018-05-30 20:25 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy, qemu-devel, qemu-block
Cc: famz, quintela, dgilbert, qemu-stable, stefanha, den
On 05/30/2018 07:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> dirty_bitmap_load_header return code is obtained but not handled. Fix
> this.
>
> Bug was introduced in b35ebdf076d697bc
> "migration: add postcopy migration of dirty bitmaps" with the whole
> function.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: fix dirty_bitmap_load
2018-05-30 11:24 [Qemu-devel] [PATCH] migration/block-dirty-bitmap: fix dirty_bitmap_load Vladimir Sementsov-Ogievskiy
2018-05-30 15:22 ` Eric Blake
2018-05-30 20:25 ` John Snow
@ 2018-06-15 11:24 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2018-06-15 11:24 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy
Cc: qemu-devel, qemu-block, quintela, famz, stefanha, den, jsnow,
qemu-stable, eblake
* Vladimir Sementsov-Ogievskiy (vsementsov@virtuozzo.com) wrote:
> dirty_bitmap_load_header return code is obtained but not handled. Fix
> this.
>
> Bug was introduced in b35ebdf076d697bc
> "migration: add postcopy migration of dirty bitmaps" with the whole
> function.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Queued via migration
> ---
> migration/block-dirty-bitmap.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
> index 8819aabe3a..2c541c985d 100644
> --- a/migration/block-dirty-bitmap.c
> +++ b/migration/block-dirty-bitmap.c
> @@ -672,6 +672,9 @@ static int dirty_bitmap_load(QEMUFile *f, void *opaque, int version_id)
>
> do {
> ret = dirty_bitmap_load_header(f, &s);
> + if (ret < 0) {
> + return ret;
> + }
>
> if (s.flags & DIRTY_BITMAP_MIG_FLAG_START) {
> ret = dirty_bitmap_load_start(f, &s);
> --
> 2.11.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-15 11:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-30 11:24 [Qemu-devel] [PATCH] migration/block-dirty-bitmap: fix dirty_bitmap_load Vladimir Sementsov-Ogievskiy
2018-05-30 15:22 ` Eric Blake
2018-05-30 20:25 ` John Snow
2018-06-15 11:24 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).