From: Thomas Huth <thuth@redhat.com>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v4 4/5] m68k: add a system controller
Date: Mon, 8 Mar 2021 07:53:33 +0100 [thread overview]
Message-ID: <cb15e697-be77-5cbc-ec4d-555955963d65@redhat.com> (raw)
In-Reply-To: <20210307164828.87348-5-laurent@vivier.eu>
On 07/03/2021 17.48, Laurent Vivier wrote:
> Add a system controller for the m68k-virt machine.
> This controller allows the kernel to power off or reset the machine.
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/hw/misc/m68k_virt_ctrl.h | 22 +++++
> hw/misc/m68k_virt_ctrl.c | 152 +++++++++++++++++++++++++++++++
Wouldn't it make more sense to place this in hw/m68k than hw/misc ?
Thomas
next prev parent reply other threads:[~2021-03-08 6:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 16:48 [PATCH v4 0/5] m68k: add Virtual M68k Machine Laurent Vivier
2021-03-07 16:48 ` [PATCH v4 1/5] char: add goldfish-tty Laurent Vivier
2021-03-07 19:24 ` Philippe Mathieu-Daudé
2021-03-07 19:57 ` Laurent Vivier
2021-03-08 0:41 ` Richard Henderson
2021-03-07 16:48 ` [PATCH v4 2/5] intc: add goldfish-pic Laurent Vivier
2021-03-07 16:48 ` [PATCH v4 3/5] m68k: add an interrupt controller Laurent Vivier
2021-03-07 16:48 ` [PATCH v4 4/5] m68k: add a system controller Laurent Vivier
2021-03-08 6:53 ` Thomas Huth [this message]
2021-03-07 16:48 ` [PATCH v4 5/5] m68k: add Virtual M68k Machine Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb15e697-be77-5cbc-ec4d-555955963d65@redhat.com \
--to=thuth@redhat.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).