From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Gregor Riepl <onitake@gmail.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Zach van Rijn <me@zv.io>
Subject: Re: [PATCH-for-8.0] linux-user/sparc: Don't use 16-bit UIDs on SPARC V9
Date: Thu, 30 Mar 2023 14:55:19 +0200 [thread overview]
Message-ID: <cb1daac2-d4cd-5291-f643-0bc4536f2c58@vivier.eu> (raw)
In-Reply-To: <20230327131910.78564-1-philmd@linaro.org>
Le 27/03/2023 à 15:19, Philippe Mathieu-Daudé a écrit :
> The 64-bit SPARC V9 syscall ABI uses 32-bit UIDs. Only enable
> the 16-bit UID wrappers for 32-bit SPARC (V7 and V8).
>
> Possibly missed in commit 992f48a036 ("Support for 32 bit
> ABI on 64 bit targets (only enabled Sparc64)").
>
> Reported-by: Gregor Riepl <onitake@gmail.com>
> Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Tested-by: Zach van Rijn <me@zv.io>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1394
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> linux-user/syscall_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index 614a1cbc8e..cc37054cb5 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
> @@ -61,7 +61,7 @@
>
> #if (defined(TARGET_I386) && defined(TARGET_ABI32)) \
> || (defined(TARGET_ARM) && defined(TARGET_ABI32)) \
> - || defined(TARGET_SPARC) \
> + || (defined(TARGET_SPARC) && defined(TARGET_ABI32)) \
> || defined(TARGET_M68K) || defined(TARGET_SH4) || defined(TARGET_CRIS)
> /* 16 bit uid wrappers emulation */
> #define USE_UID16
Acked-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2023-03-30 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 13:19 [PATCH-for-8.0] linux-user/sparc: Don't use 16-bit UIDs on SPARC V9 Philippe Mathieu-Daudé
2023-03-27 17:47 ` Richard Henderson
2023-03-30 12:55 ` Laurent Vivier [this message]
2023-03-30 14:21 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb1daac2-d4cd-5291-f643-0bc4536f2c58@vivier.eu \
--to=laurent@vivier.eu \
--cc=atar4qemu@gmail.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=me@zv.io \
--cc=onitake@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).