From: Paolo Bonzini <pbonzini@redhat.com>
To: Felipe Franciosi <felipe@nutanix.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Marc-Andre Lureau <marcandre.lureau@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 2/3] vus: Introduce vhost-user-scsi host device
Date: Tue, 3 Jan 2017 10:32:43 +0100 [thread overview]
Message-ID: <cb1de694-c254-266e-016e-4bae883a5207@redhat.com> (raw)
In-Reply-To: <32782693-D91F-4920-82B5-FBE7AC22B739@nutanix.com>
On 02/01/2017 19:07, Felipe Franciosi wrote:
>
>> On 2 Jan 2017, at 10:25, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>>
>>
>> On 21/12/2016 23:17, Felipe Franciosi wrote:
>>> To use it, one must configure Qemu with --enable-vhost-user-scsi and
>>> start Qemu with a command line equivalent to:
>>>
>>> qemu-system-x86_64 \
>>> -chardev socket,id=vus0,path=/tmp/vus.sock \
>>> -device vhost-user-scsi-pci,chardev=vus0,bus=pci.0,addr=...
>>>
>>> A separate commit presents a sample application linked with libiscsi to
>>> provide a backend for vhost-user-scsi.
>>
>> Please place CONFIG_VHOST_USER_SCSI=$(CONFIG_POSIX) symbol in
>> default-configs/ (so that it is enabled by default on non-Windows hosts)
>> instead of having the configure option. Otherwise, the patches look good!
>
> Thanks, will do that and send a v4.
>
> Do you want any entries on MAINTAINERS for this code or are you happy to take care of it under hw/scsi/* ?
It's okay to have it under hw/scsi/*.
Paolo
next prev parent reply other threads:[~2017-01-03 9:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 22:17 [Qemu-devel] [PATCH v3 0/3] Introduce vhost-user-scsi and sample application Felipe Franciosi
2016-12-21 22:17 ` [Qemu-devel] [PATCH v3 1/3] vhost-scsi: create a vhost-scsi-common abstraction Felipe Franciosi
2016-12-21 22:17 ` [Qemu-devel] [PATCH v3 2/3] vus: Introduce vhost-user-scsi host device Felipe Franciosi
2017-01-02 10:25 ` Paolo Bonzini
2017-01-02 18:07 ` Felipe Franciosi
2017-01-03 9:32 ` Paolo Bonzini [this message]
2017-01-13 0:31 ` Felipe Franciosi
2017-01-16 16:43 ` Paolo Bonzini
2016-12-21 22:17 ` [Qemu-devel] [PATCH v3 3/3] vus: Introduce a vhost-user-scsi sample application Felipe Franciosi
2016-12-21 22:22 ` [Qemu-devel] [PATCH v3 0/3] Introduce vhost-user-scsi and " Felipe Franciosi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb1de694-c254-266e-016e-4bae883a5207@redhat.com \
--to=pbonzini@redhat.com \
--cc=felipe@nutanix.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).