From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Andrew Jones <ajones@ventanamicro.com>, Ben Dooks <qemu@ben.fluff.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
alistair@alistair23.me, peter.maydell@linaro.org,
qemu-riscv@nongnu.org
Subject: Re: add qemu_fdt_setprop_strings
Date: Fri, 21 Oct 2022 11:04:54 +0200 [thread overview]
Message-ID: <cb274017-85af-c603-778f-f2017e59e1d4@linaro.org> (raw)
In-Reply-To: <20221021070047.225ngzlqqwsvgbqw@kamzik>
On 21/10/22 09:00, Andrew Jones wrote:
> On Fri, Oct 21, 2022 at 06:58:02AM +0100, Ben Dooks wrote:
>> Add a qemu_fdt_setprop_strings to set a string array into a device-tree.
>>
>> Only minor updates from v4 to fix a couple of minor patch issues.
>
> Please see the comments I made on patch 1 of the v4 series, they should
> be addressed. Also, I'm pretty sure I gave r-b's on most, or the rest,
> of the series, but I don't see those here in v5. And, please CC previous
> reviewers when sending out new versions. Finally, why not generate this
> cover letter with git-format-patch?
Or git-publish:
https://github.com/stefanha/git-publish
next prev parent reply other threads:[~2022-10-21 9:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 5:58 add qemu_fdt_setprop_strings Ben Dooks
2022-10-21 5:58 ` [PATCH v5 1/6] device_tree: add qemu_fdt_setprop_strings() helper Ben Dooks
2022-10-21 6:56 ` Andrew Jones
2022-10-21 5:58 ` [PATCH v5 2/6] hw/core: don't check return on qemu_fdt_setprop_string_array() Ben Dooks
2022-10-21 5:58 ` [PATCH v5 3/6] hw/riscv: use qemu_fdt_setprop_strings() for string arrays Ben Dooks
2022-10-21 5:58 ` [PATCH v5 4/6] hw/core: use qemu_fdt_setprop_strings() Ben Dooks
2022-10-21 5:58 ` [PATCH v5 5/6] hw/mips: " Ben Dooks
2022-10-21 9:05 ` Philippe Mathieu-Daudé
2022-10-21 5:58 ` [PATCH v5 6/6] hw/arm: change to " Ben Dooks
2022-10-21 7:00 ` add qemu_fdt_setprop_strings Andrew Jones
2022-10-21 9:04 ` Philippe Mathieu-Daudé [this message]
2022-10-24 15:18 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb274017-85af-c603-778f-f2017e59e1d4@linaro.org \
--to=philmd@linaro.org \
--cc=ajones@ventanamicro.com \
--cc=alistair@alistair23.me \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu@ben.fluff.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).