From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
"Stefan Hajnoczi" <stefanha@redhat.com>
Cc: Fam Zheng <fam@euphon.net>, Paolo Bonzini <pbonzini@redhat.com>,
Shaju Abraham <shaju.abraham@nutanix.com>,
qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Revert "ide/ahci: Check for -ECANCELED in aio callbacks"
Date: Tue, 30 Jul 2019 08:50:14 -0400 [thread overview]
Message-ID: <cb2d9f43-1b14-9495-1928-a4ef271c77db@redhat.com> (raw)
In-Reply-To: <7324bc78-1d7b-7b7f-272d-c2932651b007@redhat.com>
On 7/30/19 5:54 AM, Philippe Mathieu-Daudé wrote:
> Hi John,
>
> On 7/30/19 12:36 AM, John Snow wrote:
>> This reverts commit 0d910cfeaf2076b116b4517166d5deb0fea76394.
>>
>> It's not correct to just ignore an error code in a callback; we need to
>> handle that error and possible report failure to the guest so that they
>> don't wait indefinitely for an operation that will now never finish.
>
> Is this 4.1 material? It looks so.
>
Nah. This reverts a commit from 2014. I have no valid argument for why
this is critical :)
Thanks for checking!
--js
next prev parent reply other threads:[~2019-07-30 12:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 22:36 [Qemu-devel] [PATCH] Revert "ide/ahci: Check for -ECANCELED in aio callbacks" John Snow
2019-07-30 9:54 ` Philippe Mathieu-Daudé
2019-07-30 11:37 ` Paolo Bonzini
2019-07-30 12:47 ` Philippe Mathieu-Daudé
2019-07-30 12:50 ` John Snow [this message]
2019-08-13 22:48 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb2d9f43-1b14-9495-1928-a4ef271c77db@redhat.com \
--to=jsnow@redhat.com \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=shaju.abraham@nutanix.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).