From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA0CC0044D for ; Mon, 16 Mar 2020 20:17:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F5FC20658 for ; Mon, 16 Mar 2020 20:17:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FoJB4AMP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F5FC20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDwAp-0007kd-Ks for qemu-devel@archiver.kernel.org; Mon, 16 Mar 2020 16:17:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35019) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDwA9-0007D4-Q4 for qemu-devel@nongnu.org; Mon, 16 Mar 2020 16:16:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDwA8-0005pA-Ns for qemu-devel@nongnu.org; Mon, 16 Mar 2020 16:16:37 -0400 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]:35426) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDwA8-0005kb-GU for qemu-devel@nongnu.org; Mon, 16 Mar 2020 16:16:36 -0400 Received: by mail-pj1-x1043.google.com with SMTP id mq3so9284677pjb.0 for ; Mon, 16 Mar 2020 13:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FhITnVcXOIhnDs6uomlU7NICQahFSW5Nno5Xh6Sq2S4=; b=FoJB4AMPXLMvqJ/PwEVqdjzE4axxigJIAJXVIgptDfwHvaprZTEE5YOdc/y1goBOvu 4ZZaQY5MzFzgkwfBhc4G6K7luBCzEvSeoGcAaYETYA7PnJtCwMVh8x/6uMPN5r/rJgGe YvRU50ybHtZ0mOlJF+eVXe7HpEaZrykr6uypERcyCu8bFl/CtCsdL0lE+IqAYOw0mHse AftV/lzKuiYcwTV9dV9xl96SMyhsFYDe2VXitZfHl2W6PrAaSmtQp92OiscOzfWMIIXG 1Ek0faM4ssdTahTxkQcazBtwMjZurKMef+/NGaY6EsxiQaKqFpYLIQQbwlUIk/7+peV1 mfuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FhITnVcXOIhnDs6uomlU7NICQahFSW5Nno5Xh6Sq2S4=; b=ftKpQNRzJvxUbH6VSEESEbbf3xGRjx6ua93QtNu5nfIetwqUYz4HE313NZoS9bziW7 JhlHzrGxZmEmKy5xzq6rQtsrEJ6yP0yav3rW7UN4UDNKXmBO7tdNM8xSiuZhBjxdZuO4 Co5baMKlcKoorIzFCrLEl8cOVuRvr95vyQBwbc/SMbynIe5jObmX96UfAiwg+pJdSLle EPBj1sfYvsAB8a/YD5UbMCY3yXgTrGdI4niirwc7ItUbP2/chxPE2vfeSdnqI+ZH1sLV g68mSMTvJZj/p9WJjDOwOQDtjmaRMhm+xUtfail4D5t16DiWPFpziqCE2FnRzVHRqoF6 Zfdw== X-Gm-Message-State: ANhLgQ0nOKoyRYs7JeumNpPFrfLbVfbqG2yF9sG4QUYQv/krRjHI4Z8J vdM7ixDoQcPzGbHv5Ajsu1Oa8w== X-Google-Smtp-Source: ADFU+vvXz6vFHeF1yKbPbpgcnf+53vX8VlT/JrnRIIROKRDHpkh55asOanh1rtAanRMRpWVarvC1uw== X-Received: by 2002:a17:90b:d8d:: with SMTP id bg13mr1312350pjb.29.1584389794888; Mon, 16 Mar 2020 13:16:34 -0700 (PDT) Received: from [192.168.1.11] (97-126-123-70.tukw.qwest.net. [97.126.123.70]) by smtp.gmail.com with ESMTPSA id 67sm677082pfe.168.2020.03.16.13.16.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2020 13:16:34 -0700 (PDT) Subject: Re: [PATCH v3 01/19] target/arm: Rename KVM set_feature() as kvm_set_feature() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200316160634.3386-1-philmd@redhat.com> <20200316160634.3386-2-philmd@redhat.com> From: Richard Henderson Message-ID: Date: Mon, 16 Mar 2020 13:16:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200316160634.3386-2-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::1043 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Thomas Huth , kvm@vger.kernel.org, qemu-arm@nongnu.org, Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/16/20 9:06 AM, Philippe Mathieu-Daudé wrote: > +++ b/target/arm/kvm32.c > @@ -22,7 +22,7 @@ > #include "internals.h" > #include "qemu/log.h" > > -static inline void set_feature(uint64_t *features, int feature) > +static inline void kvm_set_feature(uint64_t *features, int feature) Why, what's wrong with the existing name? Plus, with patch 2, you can just remove these. r~