From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, qemu-devel@nongnu.org,
den@openvz.org, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-4.1] util/hbitmap: update orig_size on truncate
Date: Mon, 5 Aug 2019 17:38:42 +0200 [thread overview]
Message-ID: <cb3c73a4-e851-0329-91ad-d9e6fb342ca3@redhat.com> (raw)
In-Reply-To: <20190805120120.23585-1-vsementsov@virtuozzo.com>
[-- Attachment #1.1: Type: text/plain, Size: 524 bytes --]
On 05.08.19 14:01, Vladimir Sementsov-Ogievskiy wrote:
> Without this, hbitmap_next_zero and hbitmap_next_dirty_area are broken
> after truncate. So, orig_size is broken since it's introduction in
> 76d570dc495c56bb.
>
> Fixes: 76d570dc495c56bb
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
A unit test as a follow-up would indeed be nice, but I’ll just take it
now anyway.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-08-05 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 12:01 [Qemu-devel] [PATCH for-4.1] util/hbitmap: update orig_size on truncate Vladimir Sementsov-Ogievskiy
2019-08-05 12:19 ` Max Reitz
2019-08-05 14:50 ` Paolo Bonzini
2019-08-05 15:38 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb3c73a4-e851-0329-91ad-d9e6fb342ca3@redhat.com \
--to=mreitz@redhat.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).