From: Richard Henderson <richard.henderson@linaro.org>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-devel@nongnu.org
Cc: "Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Weiwei Li" <liwei1518@gmail.com>,
philmd@linaro.org, "Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
qemu-riscv@nongnu.org,
"Alistair Francis" <alistair.francis@wdc.com>
Subject: Re: [PATCH 05/10] include/semihosting/common-semi: extract common_semi API
Date: Fri, 1 Aug 2025 09:28:33 +1000 [thread overview]
Message-ID: <cb4ffd4a-48fe-411e-8064-39059317b952@linaro.org> (raw)
In-Reply-To: <20250730220621.1142496-6-pierrick.bouvier@linaro.org>
On 7/31/25 08:06, Pierrick Bouvier wrote:
> We transform target/{arm,riscv}/common-semi-target.h headers to proper
> compilation units, and use them in arm-compat-semi.c.
>
> This way, we can include only the declaration header (which is target
> agnostic), and selectively link the appropriate implementation based on
> current target.
>
> Signed-off-by: Pierrick Bouvier<pierrick.bouvier@linaro.org>
> ---
> include/semihosting/common-semi.h | 5 +++++
> semihosting/arm-compat-semi.c | 3 +--
> ...mmon-semi-target.h => common-semi-target.c} | 18 ++++++++----------
> ...mmon-semi-target.h => common-semi-target.c} | 17 ++++++++---------
> target/arm/meson.build | 4 ++++
> target/riscv/meson.build | 4 ++++
> 6 files changed, 30 insertions(+), 21 deletions(-)
> rename target/arm/{common-semi-target.h => common-semi-target.c} (66%)
> rename target/riscv/{common-semi-target.h => common-semi-target.c} (60%)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2025-07-31 23:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 22:06 [PATCH 00/10] single-binary: compile once semihosting Pierrick Bouvier
2025-07-30 22:06 ` [PATCH 01/10] semihosting/syscalls: compile once in system and per target for user mode Pierrick Bouvier
2025-07-31 23:13 ` Richard Henderson
2025-08-01 1:42 ` Pierrick Bouvier
2025-07-30 22:06 ` [PATCH 02/10] semihosting/guestfd: compile once for system/user Pierrick Bouvier
2025-07-31 23:15 ` Richard Henderson
2025-08-01 1:41 ` Pierrick Bouvier
2025-07-30 22:06 ` [PATCH 03/10] semihosting/arm-compat-semi: remove common_semi_sys_exit_extended Pierrick Bouvier
2025-07-31 23:20 ` Richard Henderson
2025-07-30 22:06 ` [PATCH 04/10] target/{arm, riscv}/common-semi-target: eradicate target_ulong Pierrick Bouvier
2025-07-31 23:23 ` [PATCH 04/10] target/{arm,riscv}/common-semi-target: " Richard Henderson
2025-07-30 22:06 ` [PATCH 05/10] include/semihosting/common-semi: extract common_semi API Pierrick Bouvier
2025-07-31 23:28 ` Richard Henderson [this message]
2025-07-30 22:06 ` [PATCH 06/10] semihosting/arm-compat-semi: eradicate sizeof(target_ulong) Pierrick Bouvier
2025-07-31 23:28 ` Richard Henderson
2025-07-30 22:06 ` [PATCH 07/10] semihosting/arm-compat-semi: replace target_ulong with uint64_t Pierrick Bouvier
2025-07-31 23:33 ` Richard Henderson
2025-08-01 1:40 ` Pierrick Bouvier
2025-07-30 22:06 ` [PATCH 08/10] semihosting/arm-compat-semi: replace target_long with int64_t Pierrick Bouvier
2025-08-01 1:25 ` Richard Henderson
2025-08-01 1:39 ` Pierrick Bouvier
2025-07-30 22:06 ` [PATCH 09/10] semihosting/arm-compat-semi: remove dependency on cpu.h Pierrick Bouvier
2025-08-01 1:26 ` Richard Henderson
2025-07-30 22:06 ` [PATCH 10/10] semihosting/arm-compat-semi: compile once in system and per target for user mode Pierrick Bouvier
2025-08-01 1:26 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb4ffd4a-48fe-411e-8064-39059317b952@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=dbarboza@ventanamicro.com \
--cc=liwei1518@gmail.com \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).