From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EF23C87FD2 for ; Thu, 31 Jul 2025 23:29:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uhchz-0000FH-P8; Thu, 31 Jul 2025 19:29:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uhchc-00006D-I6 for qemu-devel@nongnu.org; Thu, 31 Jul 2025 19:28:53 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uhcha-0000xC-NQ for qemu-devel@nongnu.org; Thu, 31 Jul 2025 19:28:48 -0400 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-23dc5bcf49eso21685665ad.2 for ; Thu, 31 Jul 2025 16:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754004523; x=1754609323; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JK0rJE4xO/dWWwPBopC74O5EzpH8MPrs0ae4fXpqeaI=; b=y1WwLraMwexnlfkEfkjJ2XHVsVcCRT7OZiZCdLc/2GyeZdGZd6Olgpjo7pVdQ8I7Sm KIC9XgfVp8u2tIjzMC+DfnDemjxybHhqozWrfbdkxFlrJeGnv86NL99XEo1qEzXZr34U qNuJp66+5Ae2TDKHHnsQ8HopWJKYbZkhF6oqoeyYSbMdDj7yNGZ01O30puXYWUK0Ic70 dLH8xZS3Mr73eufgUUM4LMmjjfePJs0HCzGJ8rxu+XbNVZm0Bswdp332MM7av/C02/x2 pAr3KLMkoUa7pxob0f+vX1WpaotA/N0DrsPfwpM7H1oM2Sxq2iDpnK/XMP0WxOKC0GEd ghKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754004523; x=1754609323; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JK0rJE4xO/dWWwPBopC74O5EzpH8MPrs0ae4fXpqeaI=; b=gsXVke7mwwlQgXDk1HkRWsE+3ft0+w8998vyazl8lipaZLdI/4zD0uyjsogwoy5XtB E5ENT7pD+UHpgr5rae/uREN8ZZVul/b1Ah8ApXx2hmzzxlzcx9EnFYEyn8p5EuSvzOqs Ypt4cmSANf/5XgMLgQHTc8Jv0Pbe0qTGd9FaT85rYam5e8mKrsXVE5GxXtlo0rFaErkc bD9OCb5FGpGszgGff6Q4FEllrs35MVjgI05hVkjhaoTfVPgOXyiohQixMacuA+2v+5U7 FKAvxotI8V4OiEb5M3N+5ed3Epy5JkbG5XXzgs1xFQQyLyKRmU4rQaGzvxoPyRX5vhx1 gelg== X-Forwarded-Encrypted: i=1; AJvYcCUj4KvMAdXHz4eU49kEpSFLHZp2iOhMYrSAB22Qrn8sqbuB2xz9b7WpYt2MLgsfRZR5BooO0Yc/KEyL@nongnu.org X-Gm-Message-State: AOJu0Yw+SN0V4Fyx5nPyaVqJ5j2Av24A3yqM3dtD70IeX+soH5/qD34D FOqAKpEL4+LlVyRt1+xQHGAnGozAXqilNUEGTa3p66LQ0NvIGGfoM4qZWbKn8K64TYM= X-Gm-Gg: ASbGncs1ANWm7QkgEPavCs+Za2HcqAoU2sukBmJyg94D9eOP0PtPpwZxYhbmVR2vJ7P wlWeRKSLxF6UOzq5imhEsz9wnNYhQ2OZex9POOcbh+LxBh87E8h2LDacH2p5dKZI5hmIEcFTwG3 pZPLZBB9j/sFjhxUqEt/LX+6pEHWy1G0b8bsMygArrp6L5xtKeOmipFTgKMpiDagqPety5si6zd UNiWnynTlSZ0HeFEtx1ALFEuGHHlS811m5z9GeiJ5r6Jb9LcITi2tdJ/LWQ8a5IxBefPNyDO4f7 QuJaaOIqZz1yg68Y2CfG8vEby3j4N00EmHoJ1Kbg6afZnxYkxzu9Yi5MaODvbqbcSnszXvBOA7z p0RfAgSP7TUzD2YkSHVVGxlysM/yQh5wBIAQnVQU3 X-Google-Smtp-Source: AGHT+IEtLN0g4Ozxgv+CfhomlHpXaDU7HWWhYIGYe/HHJ7tfIZGhL1E2xjANeSCjEms2gs7OvrRnGg== X-Received: by 2002:a17:903:291:b0:240:3ed3:13e7 with SMTP id d9443c01a7336-24096b1ca5bmr121316935ad.42.1754004522774; Thu, 31 Jul 2025 16:28:42 -0700 (PDT) Received: from [192.168.4.112] ([180.233.125.160]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241e8aab0ffsm27831675ad.166.2025.07.31.16.28.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Jul 2025 16:28:42 -0700 (PDT) Message-ID: Date: Fri, 1 Aug 2025 09:28:33 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/10] include/semihosting/common-semi: extract common_semi API To: Pierrick Bouvier , qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?Q?Alex_Benn=C3=A9e?= , Weiwei Li , philmd@linaro.org, Liu Zhiwei , Palmer Dabbelt , qemu-riscv@nongnu.org, Alistair Francis References: <20250730220621.1142496-1-pierrick.bouvier@linaro.org> <20250730220621.1142496-6-pierrick.bouvier@linaro.org> From: Richard Henderson Content-Language: en-US In-Reply-To: <20250730220621.1142496-6-pierrick.bouvier@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/31/25 08:06, Pierrick Bouvier wrote: > We transform target/{arm,riscv}/common-semi-target.h headers to proper > compilation units, and use them in arm-compat-semi.c. > > This way, we can include only the declaration header (which is target > agnostic), and selectively link the appropriate implementation based on > current target. > > Signed-off-by: Pierrick Bouvier > --- > include/semihosting/common-semi.h | 5 +++++ > semihosting/arm-compat-semi.c | 3 +-- > ...mmon-semi-target.h => common-semi-target.c} | 18 ++++++++---------- > ...mmon-semi-target.h => common-semi-target.c} | 17 ++++++++--------- > target/arm/meson.build | 4 ++++ > target/riscv/meson.build | 4 ++++ > 6 files changed, 30 insertions(+), 21 deletions(-) > rename target/arm/{common-semi-target.h => common-semi-target.c} (66%) > rename target/riscv/{common-semi-target.h => common-semi-target.c} (60%) Reviewed-by: Richard Henderson r~