From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH] tests/functional: Bump timeouts of functional tests
Date: Thu, 7 Nov 2024 08:00:52 +0100 [thread overview]
Message-ID: <cb547325-b03e-4ff7-a47c-b83dd46dd3c4@redhat.com> (raw)
In-Reply-To: <Zyuvphr22mUSxA-i@redhat.com>
On 06/11/2024 19.04, Daniel P. Berrangé wrote:
> On Wed, Nov 06, 2024 at 06:09:46PM +0100, Thomas Huth wrote:
>> When building QEMU with "--enable-debug" and running the tests
>> in parallel with "make -j$(nproc) check-functional", many tests are
>> still timing out due to our conservative timeout settings. Bump
>> the timeouts of the problematic tests and also increase the default
>> timeout to 90 seconds (from 60 seconds) to be on the safe side.
>
> Rather than tweak individual tests, how about we just apply
> a uniform x3 multiplier when --enable-debug is present,
> including on all the non-listed tests which have the default
> timeout?
That might be helpful, could you suggest a patch?
Anyway, I think we still should include this patch here since some people
also still might have older, slower computers, so it would be good to have
some relaxed timeout for certain tests anyway.
Thomas
prev parent reply other threads:[~2024-11-07 7:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 17:09 [PATCH] tests/functional: Bump timeouts of functional tests Thomas Huth
2024-11-06 17:21 ` Pierrick Bouvier
2024-11-06 17:26 ` Peter Maydell
2024-11-06 17:30 ` Pierrick Bouvier
2024-11-06 17:40 ` Thomas Huth
2024-11-06 18:01 ` Pierrick Bouvier
2024-11-07 9:56 ` Richard Henderson
2024-11-06 18:04 ` Daniel P. Berrangé
2024-11-07 7:00 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb547325-b03e-4ff7-a47c-b83dd46dd3c4@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).