From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: "Lluís Vilanova" <vilanova@ac.upc.edu>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] tracetool: improve error messages
Date: Wed, 10 Jan 2018 14:48:16 -0600 [thread overview]
Message-ID: <cb5cf329-50b6-845b-ff74-cd0001778611@redhat.com> (raw)
In-Reply-To: <20180110202553.31889-1-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
On 01/10/2018 02:25 PM, Stefan Hajnoczi wrote:
> This series improves the tracetool error messages to make them more
> user-friendly.
>
> Stefan Hajnoczi (3):
> tracetool: prefix parse errors with line numbers
> tracetool: clarify that "formats" means "format strings"
> tracetool: report error on foo() instead of foo(void)
Series:
Reviewed-by: Eric Blake <eblake@redhat.com>
but see nit on patch 1
>
> scripts/tracetool/__init__.py | 19 +++++++++++++------
> 1 file changed, 13 insertions(+), 6 deletions(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-01-10 20:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 20:25 [Qemu-devel] [PATCH 0/3] tracetool: improve error messages Stefan Hajnoczi
2018-01-10 20:25 ` [Qemu-devel] [PATCH 1/3] tracetool: prefix parse errors with line numbers Stefan Hajnoczi
2018-01-10 20:47 ` Eric Blake
2018-01-10 20:25 ` [Qemu-devel] [PATCH 2/3] tracetool: clarify that "formats" means "format strings" Stefan Hajnoczi
2018-01-10 20:25 ` [Qemu-devel] [PATCH 3/3] tracetool: report error on foo() instead of foo(void) Stefan Hajnoczi
2018-01-10 20:48 ` Eric Blake [this message]
2018-01-15 14:03 ` [Qemu-devel] [PATCH 0/3] tracetool: improve error messages Stefan Hajnoczi
2018-01-10 21:06 ` no-reply
2018-01-15 14:11 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb5cf329-50b6-845b-ff74-cd0001778611@redhat.com \
--to=eblake@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).