From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebqCv-0004M7-HK for qemu-devel@nongnu.org; Wed, 17 Jan 2018 11:04:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebqCr-0000Me-Is for qemu-devel@nongnu.org; Wed, 17 Jan 2018 11:04:57 -0500 References: <1516203816-19374-1-git-send-email-imammedo@redhat.com> <1516203816-19374-13-git-send-email-imammedo@redhat.com> From: David Hildenbrand Message-ID: Date: Wed, 17 Jan 2018 17:04:31 +0100 MIME-Version: 1.0 In-Reply-To: <1516203816-19374-13-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH 12/24] s390x: cpu: add TARGET_DEFAULT_CPU_TYPE macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: Alexander Graf , qemu-s390x@nongnu.org, Laurent Vivier , Richard Henderson On 17.01.2018 16:43, Igor Mammedov wrote: > it will be used for for 2 purposes, 1st is to > provide to cpu name resolving class for machine 'none' > cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model) > and later to drop a bunch of ifdefs *-user/main.c that > set default cpu_model. > > Use default value from linux-user for TARGET_DEFAULT_CPU_TYPE. > > Signed-off-by: Igor Mammedov > --- > CC: Richard Henderson > CC: Alexander Graf > CC: qemu-s390x@nongnu.org > --- > target/s390x/cpu.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h > index 1a8b6b9..174624a 100644 > --- a/target/s390x/cpu.h > +++ b/target/s390x/cpu.h > @@ -731,6 +731,7 @@ void s390_set_qemu_cpu_model(uint16_t type, uint8_t gen, uint8_t ec_ga, > > #define S390_CPU_TYPE_SUFFIX "-" TYPE_S390_CPU > #define S390_CPU_TYPE_NAME(name) (name S390_CPU_TYPE_SUFFIX) > +#define TARGET_DEFAULT_CPU_TYPE S390_CPU_TYPE_NAME("qemu") > > /* you can call this signal handler from your SIGBUS and SIGSEGV > signal handlers to inform the virtual CPU of exceptions. non zero > At least from a !KVM perspective this is correct. And that is at least relevant for linux-user. I doubt that this is relevant for KVM. The "none" machine cannot be used either way and CPU models are sensed via qmp. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb