Re: [PATCH v2 3/5] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

[Stefan Berger <stefanb@linux.ibm.com>]

On 6/9/20 8:54 AM, Eric Auger wrote:
> bios-tables-test executes SeaBIOS. Indeed FW is needed to
> fetch tables from QEMU and put them into the guest RAM. Also
> the FW patches cross table pointers. At some point, SeaBIOS
> ends up calling the TPM2_CC_HierarchyControl command with
> TPM2_ST_SESSIONS tag, most probably steming from
> tpm_set_failure/tpm20_hierarchycontrol SeaBIOS call path.
> This causes an assert() in the qtest tpm emulation code.
>
> As the goal here is not to boot SeaBIOS completely but just
> let it grab the ACPI tables and consolidate them, let's just
> remove the assert().
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>


>
> ---
>
> RFC -> PATCH:
> - reword the commit message
> ---
>   tests/qtest/tpm-emu.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/tests/qtest/tpm-emu.c b/tests/qtest/tpm-emu.c
> index c43ac4aef8..298d0eec74 100644
> --- a/tests/qtest/tpm-emu.c
> +++ b/tests/qtest/tpm-emu.c
> @@ -49,7 +49,6 @@ static void *tpm_emu_tpm_thread(void *data)
>           s->tpm_msg->tag = be16_to_cpu(s->tpm_msg->tag);
>           s->tpm_msg->len = be32_to_cpu(s->tpm_msg->len);
>           g_assert_cmpint(s->tpm_msg->len, >=, minhlen);
> -        g_assert_cmpint(s->tpm_msg->tag, ==, TPM2_ST_NO_SESSIONS);
>   
>           s->tpm_msg = g_realloc(s->tpm_msg, s->tpm_msg->len);
>           qio_channel_read(ioc, (char *)&s->tpm_msg->code,