From: Thomas Huth <thuth@redhat.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] tests/tcg/s390x: Allow specifying extra QEMU options on the command line
Date: Wed, 29 May 2024 13:06:54 +0200 [thread overview]
Message-ID: <cb75586d-2da5-40ea-b1b5-09def0f8c30e@redhat.com> (raw)
In-Reply-To: <20240522184116.35975-1-iii@linux.ibm.com>
On 22/05/2024 20.38, Ilya Leoshkevich wrote:
> The use case for this is `make check-tcg EXTFLAGS="-accel kvm"`,
> which allows validating the system TCG testcases on real hardware.
> EXTFLAGS name is borrowed from tests/tcg/xtensa/Makefile.softmmu-target.
> While at it, use += instead of = in order to be consistent with the
> other architectures.
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> tests/tcg/s390x/Makefile.softmmu-target | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tcg/s390x/Makefile.softmmu-target b/tests/tcg/s390x/Makefile.softmmu-target
> index 1078655dd31..4ca0dac7257 100644
> --- a/tests/tcg/s390x/Makefile.softmmu-target
> +++ b/tests/tcg/s390x/Makefile.softmmu-target
> @@ -1,6 +1,6 @@
> S390X_SRC=$(SRC_PATH)/tests/tcg/s390x
> VPATH+=$(S390X_SRC)
> -QEMU_OPTS=-action panic=exit-failure -nographic -kernel
> +QEMU_OPTS+=-action panic=exit-failure -nographic $(EXTFLAGS) -kernel
> LINK_SCRIPT=$(S390X_SRC)/softmmu.ld
> CFLAGS+=-ggdb -O0
> LDFLAGS=-nostdlib -static
Reviewed-by: Thomas Huth <thuth@redhat.com>
(sorry, I missed this for my pull request today ... I'll queue this patch
for my next one)
prev parent reply other threads:[~2024-05-29 11:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 18:38 [PATCH] tests/tcg/s390x: Allow specifying extra QEMU options on the command line Ilya Leoshkevich
2024-05-29 11:06 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb75586d-2da5-40ea-b1b5-09def0f8c30e@redhat.com \
--to=thuth@redhat.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).