From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: Leonardo Bras <leobras@redhat.com>, Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v3] migration: move migration_global_dump() to migration-hmp-cmds.c
Date: Fri, 21 Apr 2023 08:31:52 +0200 [thread overview]
Message-ID: <cb791293-934c-9ec2-517a-f6ce7dc052ef@linaro.org> (raw)
In-Reply-To: <20230420121038.25167-1-quintela@redhat.com>
On 20/4/23 14:10, Juan Quintela wrote:
> It is only used there, so we can make it static.
> Once there, remove spice.h that it is not used.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> ---
>
> fix David Edmonson ui/qemu-spice.h unintended removal
> ---
> include/migration/misc.h | 1 -
> migration/migration-hmp-cmds.c | 22 +++++++++++++++++++++-
> migration/migration.c | 19 -------------------
> 3 files changed, 21 insertions(+), 21 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-04-21 6:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 12:10 [PATCH v3] migration: move migration_global_dump() to migration-hmp-cmds.c Juan Quintela
2023-04-20 18:50 ` Peter Xu
2023-04-21 6:31 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb791293-934c-9ec2-517a-f6ce7dc052ef@linaro.org \
--to=philmd@linaro.org \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).