From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaMd9-0005w9-46 for qemu-devel@nongnu.org; Fri, 21 Dec 2018 10:22:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gaMd4-00031c-O3 for qemu-devel@nongnu.org; Fri, 21 Dec 2018 10:22:27 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:50262) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gaMd2-0002Z4-Uf for qemu-devel@nongnu.org; Fri, 21 Dec 2018 10:22:21 -0500 Received: by mail-wm1-f66.google.com with SMTP id n190so5668026wmd.0 for ; Fri, 21 Dec 2018 07:22:13 -0800 (PST) References: <20181221063002.7570-1-pbonzini@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Fri, 21 Dec 2018 16:22:10 +0100 MIME-Version: 1.0 In-Reply-To: <20181221063002.7570-1-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] i386: remove the 'INTEL_PT' CPUID bit from named CPU models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: robert.hu@intel.com, qemu-stable@nongnu.org, Robert Hoo Hi Paolo, On 12/21/18 7:30 AM, Paolo Bonzini wrote: > From: Robert Hoo > > Processor tracing is not yet implemented for KVM and it will be an > opt in feature requiring a special module parameter. > Disable it, because it is wrong to enable it by default and > it is impossible that no one has ever used it. > > Cc: qemu-stable@nongnu.org Does this patch misses Robert S-o-b? Signed-off-by: Robert Hoo > Signed-off-by: Paolo Bonzini > --- > target/i386/cpu.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index dae46f0319..9c54c41e7a 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -2493,8 +2493,7 @@ static X86CPUDefinition builtin_x86_defs[] = { > CPUID_7_0_EBX_SMAP | CPUID_7_0_EBX_CLWB | > CPUID_7_0_EBX_AVX512F | CPUID_7_0_EBX_AVX512DQ | > CPUID_7_0_EBX_AVX512BW | CPUID_7_0_EBX_AVX512CD | > - CPUID_7_0_EBX_AVX512VL | CPUID_7_0_EBX_CLFLUSHOPT | > - CPUID_7_0_EBX_INTEL_PT, > + CPUID_7_0_EBX_AVX512VL | CPUID_7_0_EBX_CLFLUSHOPT, > .features[FEAT_7_0_ECX] = > CPUID_7_0_ECX_PKU | CPUID_7_0_ECX_OSPKE | > CPUID_7_0_ECX_AVX512VNNI, > @@ -2546,7 +2545,7 @@ static X86CPUDefinition builtin_x86_defs[] = { > CPUID_7_0_EBX_HLE | CPUID_7_0_EBX_AVX2 | CPUID_7_0_EBX_SMEP | > CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_ERMS | CPUID_7_0_EBX_INVPCID | > CPUID_7_0_EBX_RTM | CPUID_7_0_EBX_RDSEED | CPUID_7_0_EBX_ADX | > - CPUID_7_0_EBX_SMAP | CPUID_7_0_EBX_INTEL_PT, > + CPUID_7_0_EBX_SMAP, > .features[FEAT_7_0_ECX] = > CPUID_7_0_ECX_VBMI | CPUID_7_0_ECX_UMIP | CPUID_7_0_ECX_PKU | > CPUID_7_0_ECX_OSPKE | CPUID_7_0_ECX_VBMI2 | CPUID_7_0_ECX_GFNI | > @@ -2604,8 +2603,7 @@ static X86CPUDefinition builtin_x86_defs[] = { > CPUID_7_0_EBX_SMAP | CPUID_7_0_EBX_CLWB | > CPUID_7_0_EBX_AVX512F | CPUID_7_0_EBX_AVX512DQ | > CPUID_7_0_EBX_AVX512BW | CPUID_7_0_EBX_AVX512CD | > - CPUID_7_0_EBX_AVX512VL | CPUID_7_0_EBX_CLFLUSHOPT | > - CPUID_7_0_EBX_INTEL_PT, > + CPUID_7_0_EBX_AVX512VL | CPUID_7_0_EBX_CLFLUSHOPT, > .features[FEAT_7_0_ECX] = > CPUID_7_0_ECX_VBMI | CPUID_7_0_ECX_UMIP | CPUID_7_0_ECX_PKU | > CPUID_7_0_ECX_OSPKE | CPUID_7_0_ECX_VBMI2 | CPUID_7_0_ECX_GFNI | >