From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00366CAC5B0 for ; Thu, 2 Oct 2025 17:41:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v4NGy-00033t-6k; Thu, 02 Oct 2025 13:39:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4NGo-0002zj-38 for qemu-devel@nongnu.org; Thu, 02 Oct 2025 13:39:14 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v4NGd-0003oY-HC for qemu-devel@nongnu.org; Thu, 02 Oct 2025 13:39:09 -0400 Received: by mail-wm1-x341.google.com with SMTP id 5b1f17b1804b1-46e4f2696bdso16284295e9.0 for ; Thu, 02 Oct 2025 10:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759426730; x=1760031530; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+V2wPuGfCio4QUFBc5XwSn82EF99kzO0rV5pMclAj8k=; b=I2grl3zJ8szvU4iwcLU3fAeVOtPrUzoVBzSyjCkieVPTmFMgrfXK1VBe2usyV4+uZL XS3hjB/TixcoA3GMdraJTEROTCi3WezMUKik8WztsQJ5KhFOpLr/6vNxxioyhbc0yr8P O3nMhfvAP03OwvQWVxThQWI+SD3mZzKmynLt0k9f7b8/GjuBJSItQAbkTS59vLx0Z2pn EzI101IzlrbqvPmf1LV0TLxCdCOxYF8b0qcrE3T+KlcIXhcRClT9YpGumdCe+D9TecHa PGBfVKKaPfr+Iybjry4bNMAefjSaIZ5HTDnRIveX+vFin/DJ/OoAAyOvxuAY0/ERIBXQ SYiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759426730; x=1760031530; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+V2wPuGfCio4QUFBc5XwSn82EF99kzO0rV5pMclAj8k=; b=ajWmUGVf0J8x6OCboPGjB0/20/FUJ/6i6XoAWewrFHjBAfY8NmglG1bl3FXJdQksyh SzZbOVAkvyBf4cpYsNYtSb2Wps0e5H0jTkGoby+gCixUI3ai7NyVjgtI7ZMa/X5jY0nr dn1330YZ1LMFthTiMH6y/ecCzHHUMAYvdpzMacQrsIT4uFLbTCT7ArYaUbIV+9dSiGS6 Tssn0KGiz+cNBwO3NVZGBgrNsldKdBbDMuuMvLutqtk2751OHLqvtbeywz8rW6Nhs8b/ d3JkH7W0QbK1IjtEZnfvklWp5bG4RlTN1tpXVD7rwmwil31vVvzvLGOqTRrCmOtTW5nj cNBQ== X-Forwarded-Encrypted: i=1; AJvYcCU/IUoYb4vBRthivN0xRAw2BDjrC4C1jzd19F4mg0aqa9SiYn3v/O97nN6dv0yjd1JjnRAJ63pwdj9T@nongnu.org X-Gm-Message-State: AOJu0Yyvv2xwGOnT7FajPeCFOC1bTDyYFCqmIVec2p+13PblAhn58QLj CUv6dD5+J8L6lcQe89vhRmSaRMBnUAvgMdDmCjk41ypI5jZzvLTii364y9A5kPYdaOc= X-Gm-Gg: ASbGnctCtlRgyYTf/mC3fHKnkoIdLcGs3j/bbZxOtSI+6mymXoqDInrq4yGVk7khtco fx+eGqGXG0L+0Ph9hCGqDPACLmnuosxrYscH24PD+cXudFguM0jVmVSPyQFEY41ws9a708V/BhX monIk7LncbHANMrOMeng1Ki9Y+ffE+HPr4NACWb82VSnE0oattdms9fNOJ47tkg5fi4BfBI+ysy g5wK2gDNiyUmFRPRB8bHxirNAv9CEIxPznDjMB61I5StsUdRr0hYqGXXyQqWdBFrUaJErsNNjXz SN3oV4PIa3GOh4WFMCkX/B5yir7ShK4gP3Q2X9TxXsaXsTAWMEH9LyQakQKQeZlD4Ta62sn55nK XLg86gQDQTqWARaUjAylemns6KlevG9Znzpp/VILKj+eWlvgJEu4ThMgGC8oyMi8dO9lZlCop5j HgOdbbpIBeDxFV7yoacw== X-Google-Smtp-Source: AGHT+IEzLXvjBFsflezIs0tpM1/mJV+Aj4RSV5J6Itd4MVihCEh67jQ9oba/kdfrPT1zTJ0LBEFfLg== X-Received: by 2002:a05:6000:2203:b0:40f:288e:9990 with SMTP id ffacd0b85a97d-425671abae4mr77123f8f.48.1759426730275; Thu, 02 Oct 2025 10:38:50 -0700 (PDT) Received: from [192.168.69.221] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8e97fbsm4401347f8f.34.2025.10.02.10.38.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Oct 2025 10:38:49 -0700 (PDT) Message-ID: Date: Thu, 2 Oct 2025 19:38:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/18] hw: Remove unnecessary 'system/ram_addr.h' header Content-Language: en-US To: Harsh Prateek Bora , qemu-devel@nongnu.org Cc: Peter Maydell , Jagannathan Raman , qemu-ppc@nongnu.org, Ilya Leoshkevich , Thomas Huth , Jason Herne , Peter Xu , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , kvm@vger.kernel.org, Christian Borntraeger , Halil Pasic , Matthew Rosato , Paolo Bonzini , "Michael S. Tsirkin" , Elena Ufimtseva , Richard Henderson , Fabiano Rosas , Eric Farman , qemu-arm@nongnu.org, qemu-s390x@nongnu.org, David Hildenbrand , Alex Williamson , Nicholas Piggin References: <20251001175448.18933-1-philmd@linaro.org> <20251001175448.18933-7-philmd@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=philmd@linaro.org; helo=mail-wm1-x341.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/10/25 17:59, Harsh Prateek Bora wrote: > > > On 10/1/25 23:24, Philippe Mathieu-Daudé wrote: >> None of these files require definition exposed by "system/ram_addr.h", >> remove its inclusion. >> >> Signed-off-by: Philippe Mathieu-Daudé >> Reviewed-by: Richard Henderson >> --- >>   hw/ppc/spapr.c                    | 1 - >>   hw/ppc/spapr_caps.c               | 1 - >>   hw/ppc/spapr_pci.c                | 1 - >>   hw/remote/memory.c                | 1 - >>   hw/remote/proxy-memory-listener.c | 1 - >>   hw/s390x/s390-virtio-ccw.c        | 1 - >>   hw/vfio/spapr.c                   | 1 - >>   hw/virtio/virtio-mem.c            | 1 - >>   8 files changed, 8 deletions(-) >> >> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c >> index 82fb23beaa8..97ab6bebd25 100644 >> --- a/hw/ppc/spapr.c >> +++ b/hw/ppc/spapr.c >> @@ -77,7 +77,6 @@ >>   #include "hw/virtio/virtio-scsi.h" >>   #include "hw/virtio/vhost-scsi-common.h" >> -#include "system/ram_addr.h" >>   #include "system/confidential-guest-support.h" >>   #include "hw/usb.h" >>   #include "qemu/config-file.h" >> diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c >> index f2f5722d8ad..0f94c192fd4 100644 >> --- a/hw/ppc/spapr_caps.c >> +++ b/hw/ppc/spapr_caps.c >> @@ -27,7 +27,6 @@ >>   #include "qapi/error.h" >>   #include "qapi/visitor.h" >>   #include "system/hw_accel.h" >> -#include "system/ram_addr.h" >>   #include "target/ppc/cpu.h" >>   #include "target/ppc/mmu-hash64.h" >>   #include "cpu-models.h" >> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c >> index 1ac1185825e..f9095552e86 100644 >> --- a/hw/ppc/spapr_pci.c >> +++ b/hw/ppc/spapr_pci.c >> @@ -34,7 +34,6 @@ >>   #include "hw/pci/pci_host.h" >>   #include "hw/ppc/spapr.h" >>   #include "hw/pci-host/spapr.h" >> -#include "system/ram_addr.h" >>   #include >>   #include "trace.h" >>   #include "qemu/error-report.h" > > I am seeing error while applying patch series: > > harshpb:patches$ git log --oneline -n1 > 29b77c1a2d (HEAD -> review-20251002, upstream/master, master) Merge tag > 'rust-ci-pull-request' of https://gitlab.com/marcandre.lureau/qemu into > staging > harshpb:patches$ git am ./ > v2_20251001_philmd_system_physmem_extract_api_out_of_system_ram_addr_h_header.mbx > > > Applying: system/ram_addr: Remove unnecessary 'exec/cpu-common.h' header > Applying: accel/kvm: Include missing 'exec/target_page.h' header > Applying: hw/s390x/s390-stattrib: Include missing 'exec/target_page.h' > header > Applying: hw/vfio/listener: Include missing 'exec/target_page.h' header > Applying: target/arm/tcg/mte: Include missing 'exec/target_page.h' header > Applying: hw: Remove unnecessary 'system/ram_addr.h' header > Applying: system/physmem: Un-inline cpu_physical_memory_get_dirty_flag() > Applying: system/physmem: Un-inline cpu_physical_memory_is_clean() > Applying: system/physmem: Un-inline > cpu_physical_memory_range_includes_clean() > Applying: system/physmem: Un-inline cpu_physical_memory_set_dirty_flag() > Applying: system/physmem: Un-inline cpu_physical_memory_set_dirty_range() > Applying: system/physmem: Remove _WIN32 #ifdef'ry > Applying: system/physmem: Un-inline > cpu_physical_memory_set_dirty_lebitmap() > Applying: system/physmem: Un-inline > cpu_physical_memory_dirty_bits_cleared() > Applying: system/physmem: Reduce cpu_physical_memory_clear_dirty_range() > scope > Applying: system/physmem: Reduce cpu_physical_memory_sync_dirty_bitmap() > scope > Applying: system/physmem: Drop 'cpu_' prefix in Physical Memory API > error: patch failed: hw/vfio/container.c:255 > error: hw/vfio/container.c: patch does not apply > Patch failed at 0017 system/physmem: Drop 'cpu_' prefix in Physical > Memory API > hint: Use 'git am --show-current-patch=diff' to see the failed patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > harshpb:patches$ > > However, changes for ppc/spapr looks fine to me. Sorry, I forgot the 'Based-on' tag on v1 and added it separately: https://lore.kernel.org/qemu-devel/ef4baceb-671f-4afe-8a41-cafb89ea1707@linaro.org/ then forgot to add it again on v2 :/ > > Thanks > Harsh