From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB4FDC61D97 for ; Thu, 23 Nov 2023 17:40:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6Dgf-00025m-KM; Thu, 23 Nov 2023 12:40:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6Dgd-000255-45 for qemu-devel@nongnu.org; Thu, 23 Nov 2023 12:40:23 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6DgY-0004oD-3E for qemu-devel@nongnu.org; Thu, 23 Nov 2023 12:40:22 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-332e42469f0so466060f8f.1 for ; Thu, 23 Nov 2023 09:40:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700761214; x=1701366014; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zoQw7LR6l5Q+I59aE8lGQNHXwu5AaRNtWtfQmuWK56o=; b=TOdIsqWJ3lYkGiF/NRJJwFTNWMdp7/mVq9phkKxOxqKR/u2vJGNQFxn7E3sFUSMkXB LFs6ut3cDHK+8RB5l8GB0+C/MOUtUPzx3fmELeRY5VVNUNWWLwiwhQY8rTdkeowKgPo0 YKpKOYPz8LWWVD9wxV/ULCcSO4rjKYP/GXoqGdWwLT55UKh8UnhKMKPANuBAPdeqNnQN pdMYLnnqIBo+NwFCVy3mFwT0CjtEkNg1OL0mGCkb3pQBiiEdF/VjZaJLUwTs1azVqki5 98qrPRz/RINrxhr921ZT3LevAQ5EQb6Rxb4K0wUCILsINefSoRHfb8eGRIEGgIcjFeLA oBdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700761214; x=1701366014; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zoQw7LR6l5Q+I59aE8lGQNHXwu5AaRNtWtfQmuWK56o=; b=j41QUKD8gWPInxolcRl2Q/O+ZmPPjLeh76uIqyI2SUu2jYlJzmYYhzvfsOatba7Azp QadaKk7CWMRvFpzecgVvCJ2+9iyWiMBKqrxUW/wsF3TLA266xTGKWwBsvdIHpOOzTv/W tFm5IWIFz/ygHAm8SsmYe8r4N1igoRyCunu0MSq6hx4f4m53YyR6asBxz1RKA1qB3r9T zFCtkxlo0cdugiCcfpyAL/fPW6rCQDyQF6SyGzI+dB9g5liT+DDGXtRIw4QKKLCzi/1x WxiOvcMF0ny8XwYQl7SF7rxjpoRSo5p4zqXhEBhOq39hFs1RtkRkW72aPGoexmFlOTNv 4IeA== X-Gm-Message-State: AOJu0YxI/ANpqkb71LVDYKqmUSFN3e4y76zK9RNVGVcHga052v8eJE4Y xwz0p0EMHFjsdwHnIUdtf3073Q== X-Google-Smtp-Source: AGHT+IF0E9PjAPebK4qXc14BmcPby6mahiXrlqyEDnx7DY/wfmENZya7z8zz2zX4nvm6W0COaie60w== X-Received: by 2002:adf:ec04:0:b0:32f:7db1:22fb with SMTP id x4-20020adfec04000000b0032f7db122fbmr125168wrn.28.1700761214373; Thu, 23 Nov 2023 09:40:14 -0800 (PST) Received: from [192.168.69.100] ([176.176.165.237]) by smtp.gmail.com with ESMTPSA id n9-20020a5d4209000000b00332e1fe6ebfsm2232662wrq.111.2023.11.23.09.40.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Nov 2023 09:40:13 -0800 (PST) Message-ID: Date: Thu, 23 Nov 2023 18:40:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for-9.0 00/21] target/arm: kvm cleanups Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org References: <20231123044219.896776-1-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20231123044219.896776-1-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 23/11/23 05:41, Richard Henderson wrote: > This is primarily concerned with merging kvm64.c with kvm.c > and then unexporting everything that is not required outside. > target/arm/kvm_arm.h | 203 ------ Unrelated to this series goal, but I notice half of the API takes CPUState, the other ARMCPU... $ git grep -F 'CPUState *' target/arm/kvm_arm.h | wc -l 16 $ git grep -F 'ARMCPU *' target/arm/kvm_arm.h | wc -l 14 Since this is ARM specific, I'd expect it always take ARMCPU, and call the generic KVM API casting with the CPU() macro.