From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: samuel.thibault@ens-lyon.org, j@getutm.app, pbonzini@redhat.com
Subject: Re: [PATCH v2 0/2] Update libslirp & make it a subproject
Date: Mon, 8 Mar 2021 11:02:12 +0100 [thread overview]
Message-ID: <cb8c7d87-1f1d-a262-c35a-00b34f8240f0@redhat.com> (raw)
In-Reply-To: <20210125073427.3970606-1-marcandre.lureau@redhat.com>
Hi Marc-André,
On 1/25/21 8:34 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Hi,
>
> Here is a few patches to update libslirp to git upstream.
> Since it now supports meson subproject(), adapt the build
> system to use it, and related fixes.
>
> v2:
> - fix unused variables on macos
> - fork_exec_child_setup: improve signal handling
>
> Marc-André Lureau (2):
> slirp: update to git master
> build-sys: make libslirp a meson subproject
>
> configure | 2 +-
> meson.build | 62 +++-----------------------------------------
> .gitmodules | 4 +--
> slirp | 1 -
> subprojects/libslirp | 1 +
> 5 files changed, 8 insertions(+), 62 deletions(-)
> delete mode 160000 slirp
> create mode 160000 subprojects/libslirp
Just out of curiosity, why "subprojects"? Should we move
other submodules there (meson, dtc, keycodemapdb)?
next prev parent reply other threads:[~2021-03-08 10:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 7:34 [PATCH v2 0/2] Update libslirp & make it a subproject marcandre.lureau
2021-01-25 7:34 ` [PATCH v2 1/2] slirp: update to git master marcandre.lureau
2021-03-08 6:42 ` Joelle van Dyne
2021-01-25 7:34 ` [PATCH v2 2/2] build-sys: make libslirp a meson subproject marcandre.lureau
2021-03-08 6:42 ` Joelle van Dyne
2021-03-08 10:02 ` Philippe Mathieu-Daudé [this message]
2021-03-08 10:23 ` [PATCH v2 0/2] Update libslirp & make it a subproject Marc-André Lureau
2021-03-08 11:34 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb8c7d87-1f1d-a262-c35a-00b34f8240f0@redhat.com \
--to=philmd@redhat.com \
--cc=j@getutm.app \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).