From: Auger Eric <eric.auger@redhat.com>
To: Andrew Jones <drjones@redhat.com>, Igor Mammedov <imammedo@redhat.com>
Cc: peter.maydell@linaro.org, tn@semihalf.com, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, shannon.zhao@linaro.org,
prem.mallappa@broadcom.com, christoffer.dall@linaro.org,
eric.auger.pro@gmail.com
Subject: Re: [Qemu-devel] [PATCH v2 1/2] ACPI: Add IORT Structure definition
Date: Fri, 14 Oct 2016 16:03:35 +0200 [thread overview]
Message-ID: <cb8dfdcd-1073-2608-90a6-6586fd9da80d@redhat.com> (raw)
In-Reply-To: <20161014133239.p7czyawvp45b33li@hawk.localdomain>
Hi Igor,
On 14/10/2016 15:32, Andrew Jones wrote:
> On Fri, Oct 14, 2016 at 02:42:18PM +0200, Igor Mammedov wrote:
>> On Fri, 14 Oct 2016 10:54:54 +0200
>> Eric Auger <eric.auger@redhat.com> wrote:
>>
>>> From: Prem Mallappa <prem.mallappa@broadcom.com>
>>>
>>> ACPI Spec 6.0 introduces IO Remapping Table Structure. This patch
>>> introduces the definitions required to describe the IO relationship
>>> between the PCIe root complex and the ITS.
>>>
>>> This conforms to:
>>> "IO Remapping Table System Software on ARM Platforms",
>>> Document number: ARM DEN 0049B, October 2015.
>>>
>>> Signed-off-by: Prem Mallappa <prem.mallappa@broadcom.com>
>>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>>
>> Preferred way to build/pack ACPI tables info is to use
>> build_append_foo() functions.
>
> We've raised this before with Shannon, but it was already too late
> for most tables. Now all tables in hw/arm/virt-acpi-build.c are
> done in the style of this series, and I'd prefer we keep the style
> consistent. If I ever get some free time to experiment then I might
> try rewriting all of them in the build_append_ style to see how it
> looks though.
Thank you for the info. Well so let's keep it as is if nobody objects.
Thanks
Eric
>
> Thanks,
> drew
>
next prev parent reply other threads:[~2016-10-14 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 8:54 [Qemu-devel] [PATCH v2 0/2] ACPI IORT generation for ITS support Eric Auger
2016-10-14 8:54 ` [Qemu-devel] [PATCH v2 1/2] ACPI: Add IORT Structure definition Eric Auger
2016-10-14 11:30 ` Andrew Jones
2016-10-14 11:59 ` Auger Eric
2016-10-14 12:42 ` Igor Mammedov
2016-10-14 13:32 ` Andrew Jones
2016-10-14 14:03 ` Auger Eric [this message]
2016-10-14 8:54 ` [Qemu-devel] [PATCH v2 2/2] ARM: Virt: ACPI: Build an IORT table with RC and ITS nodes Eric Auger
2016-10-14 11:57 ` Andrew Jones
2016-10-14 12:03 ` Auger Eric
2016-10-14 12:41 ` Igor Mammedov
2016-10-14 13:51 ` Auger Eric
2016-10-14 9:02 ` [Qemu-devel] [PATCH v2 0/2] ACPI IORT generation for ITS support no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb8dfdcd-1073-2608-90a6-6586fd9da80d@redhat.com \
--to=eric.auger@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=prem.mallappa@broadcom.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=tn@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).