From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyhGr-0007TI-VC for qemu-devel@nongnu.org; Wed, 21 Mar 2018 13:11:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyhGo-0006fB-Ok for qemu-devel@nongnu.org; Wed, 21 Mar 2018 13:11:29 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57900 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyhGo-0006ex-JL for qemu-devel@nongnu.org; Wed, 21 Mar 2018 13:11:26 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4761FA1BEB for ; Wed, 21 Mar 2018 17:11:26 +0000 (UTC) References: <20180312183628.394722-1-eblake@redhat.com> <20180312183628.394722-32-eblake@redhat.com> From: Eric Blake Message-ID: Date: Wed, 21 Mar 2018 12:11:21 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 31/36] monitor: enable IO thread for (qmp & !mux) typed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: "Dr. David Alan Gilbert" , Peter Xu , Markus Armbruster On 03/21/2018 07:37 AM, Max Reitz wrote: > On 2018-03-12 19:36, Eric Blake wrote: >> From: Peter Xu >> >> Start to use dedicate IO thread for QMP monitors that are not using >> MUXed chardev. >> >> Reviewed-by: Fam Zheng >> Reviewed-by: Stefan Hajnoczi >> Signed-off-by: Peter Xu >> Message-Id: <20180309090006.10018-21-peterx@redhat.com> >> Signed-off-by: Eric Blake >> --- >> monitor.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) > > It seems the iotests aren't quite ready for this change (breakage in > 040, 041, 051, 060, 085, 087, 093, 095, 109, 124, 127, 132, 136, 144, > 148, 152, 182, 183, 185, 186; and 030 hangs). Serves me right for not testing iotests on my qapi tree as rigoursly as I do on my NBD tree. Fixing this during freeze is acceptable, although I'd like it if Peter Xu can take a look instead of just me. (And still a bummer that iotests aren't being run by 'make check' or CLI to have caught it earlier?) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org