From: Thomas Huth <thuth@redhat.com>
To: Alexander Bulekov <alxndr@bu.edu>, qemu-devel@nongnu.org
Cc: f4bug@amsat.org, darren.kenny@oracle.com, bsd@redhat.com,
stefanha@redhat.com, pbonzini@redhat.com,
dimastep@yandex-team.ru
Subject: Re: [PATCH v5 00/16] Add a Generic Virtual Device Fuzzer
Date: Wed, 21 Oct 2020 15:24:43 +0200 [thread overview]
Message-ID: <cb913353-1cf9-53e4-287e-54ab580a4984@redhat.com> (raw)
In-Reply-To: <20201021010752.973230-1-alxndr@bu.edu>
On 21/10/2020 03.07, Alexander Bulekov wrote:
> v5:
> - Replace GArray-based predefined fuzzer configs with a static
> struct array
> - "General" -> "Generic"
> - Fix bugs with wrong timeout denominator and skipping DMA memwrites
> without QTEST_LOG
> v4:
> - Replace yaml + c template-based oss-fuzz configs, with C code to
> register a FuzzTarget for each config (as suggested by Paolo)
> - Replicate the functionality of address_space_write_rom to ensure
> matching behavior when QTEST_LOG is enabled
> - Improve code documentation/comments
> - Small formatting changes
> v3:
> - Use flatviews to help select regions for fuzzing
> - Meson-related changes
> - Add some documentation
> - Improve minimalization script to trim write{bwlq} commands
> v2:
> - Remove QOS dependency.
> - Add a custom crossover function
> - Fix broken minimization scripts
> - Fixes to the IO region and DMA handling code
>
> This is a general virtual-device fuzzer, designed to fuzz devices over Port IO,
> MMIO, and DMA.
Hi Alexander,
this fails to compile in the Gitlab-CI:
https://gitlab.com/huth/qemu/-/jobs/803091952#L2308
../softmmu/memory.c: In function 'flatview_for_each_range':
2309../softmmu/memory.c:663:24: error: incompatible type for argument 1 of 'cb'
2310 if (cb(fr->addr.start, fr->addr.size, fr->mr, opaque))
2311 ~~~~~~~~^~~~~~
2312../softmmu/memory.c:663:24: note: expected 'ram_addr_t' {aka 'unsigned
int'} but argument is of type 'Int128' {aka 'struct Int128'}
2313../softmmu/memory.c:663:40: error: incompatible type for argument 2 of 'cb'
2314 if (cb(fr->addr.start, fr->addr.size, fr->mr, opaque))
2315 ~~~~~~~~^~~~~
2316../softmmu/memory.c:663:40: note: expected 'ram_addr_t' {aka 'unsigned
int'} but argument is of type 'Int128' {aka 'struct Int128'}
Thomas
prev parent reply other threads:[~2020-10-21 13:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 1:07 [PATCH v5 00/16] Add a Generic Virtual Device Fuzzer Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 01/16] memory: Add FlatView foreach function Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 02/16] fuzz: Add general virtual-device fuzzer Alexander Bulekov
2020-10-21 12:44 ` Paolo Bonzini
2020-10-21 14:49 ` Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 03/16] fuzz: Add PCI features to the general fuzzer Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 04/16] fuzz: Add DMA support to the generic-fuzzer Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 05/16] fuzz: Declare DMA Read callback function Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 06/16] fuzz: Add fuzzer callbacks to DMA-read functions Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 07/16] fuzz: Add support for custom crossover functions Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 08/16] fuzz: add a DISABLE_PCI op to general-fuzzer Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 09/16] fuzz: add a crossover function to generic-fuzzer Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 10/16] scripts/oss-fuzz: Add script to reorder a general-fuzzer trace Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 11/16] scripts/oss-fuzz: Add crash trace minimization script Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 12/16] fuzz: Add instructions for using general-fuzz Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 13/16] fuzz: add an "opaque" to the FuzzTarget struct Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 14/16] fuzz: add general-fuzz configs for oss-fuzz Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 15/16] fuzz: register predefined general-fuzz configs Alexander Bulekov
2020-10-21 1:07 ` [PATCH v5 16/16] scripts/oss-fuzz: remove the general-fuzz target Alexander Bulekov
2020-10-21 13:24 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb913353-1cf9-53e4-287e-54ab580a4984@redhat.com \
--to=thuth@redhat.com \
--cc=alxndr@bu.edu \
--cc=bsd@redhat.com \
--cc=darren.kenny@oracle.com \
--cc=dimastep@yandex-team.ru \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).