From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46164)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bLWNa-0007Uz-7s
	for qemu-devel@nongnu.org; Fri, 08 Jul 2016 10:03:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bLWNW-00061t-DF
	for qemu-devel@nongnu.org; Fri, 08 Jul 2016 10:03:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60569)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bLWNW-00061L-7W
	for qemu-devel@nongnu.org; Fri, 08 Jul 2016 10:03:38 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 2A71015559
	for <qemu-devel@nongnu.org>; Fri,  8 Jul 2016 14:03:36 +0000 (UTC)
References: <20160706164246.22116-1-marcandre.lureau@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <cb9c5621-803c-f708-7330-50acd2788b9d@redhat.com>
Date: Fri, 8 Jul 2016 16:03:32 +0200
MIME-Version: 1.0
In-Reply-To: <20160706164246.22116-1-marcandre.lureau@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qemu-sockets: use qapi_free_SocketAddress
 in cleanup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org



On 06/07/2016 18:42, marcandre.lureau@redhat.com wrote:
> From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>=20
> Commit 74b6ce43e3 uses the wrong free API for a SocketAddress, that
> may leak some linked data.
>=20
> Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> ---
>  util/qemu-sockets.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index fb83d48..777af49 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -1012,7 +1012,7 @@ void socket_listen_cleanup(int fd, Error **errp)
>          }
>      }
> =20
> -    g_free(addr);
> +    qapi_free_SocketAddress(addr);
>  }
> =20
>  int socket_dgram(SocketAddress *remote, SocketAddress *local, Error **=
errp)
>=20

Queued, thanks.

Paolo