Re: [PATCH 1/5] configure: remove --with-git= option

[Thomas Huth <thuth@redhat.com>]

On 27/05/2023 11.28, Paolo Bonzini wrote:
> There is not really any scenario where one would use any other git
> binary than "the first git in the PATH" aka $(command -v git).  In
> fact for example "meson subprojects download" or scripts/checkpatch.pl
> do not obey the GIT environment variable.
> 
> Remove the unnecessary knob, but test for the presence of git in
> the configure and git-submodule.sh scripts.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   Makefile                 | 2 +-
>   configure                | 6 ++----
>   meson.build              | 1 -
>   scripts/git-submodule.sh | 8 +++++++-
>   4 files changed, 10 insertions(+), 7 deletions(-)

The commit cc84d63a42e31c2a that introduce this switch gave a
rationale:

     Some users can't run a bare 'git' command, due to need for a transparent
     proxying solution such as 'tsocks'. This adds an argument to configure to
     let users specify such a thing:
     
       ./configure --with-git="tsocks git"

But if the plain "git" command is unusable on their system,
they should likely introduce a proper wrapper on their end
for this command anyway, so IMHO it's ok if we remove this
again. Daniel, what do you think?

  Thomas