From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74DB0C46467 for ; Wed, 11 Jan 2023 05:40:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFTpb-0007cm-IO; Wed, 11 Jan 2023 00:39:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFTpa-0007cI-Cg for qemu-devel@nongnu.org; Wed, 11 Jan 2023 00:39:22 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFTpY-00026X-O2 for qemu-devel@nongnu.org; Wed, 11 Jan 2023 00:39:21 -0500 Received: by mail-pl1-x631.google.com with SMTP id jn22so15631596plb.13 for ; Tue, 10 Jan 2023 21:39:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1mILLToEQSFznoisqcOMWl3SJWfi8lRpBkCgUozEfIs=; b=sy2MKt7M0vIYExT2CmpnYfeq51Sks47HoUIweLLxVmIxqhg5Mi9QZ9Hw16ho1ZkQde uHA176M88tEEN9DdhldCN1meg8fkuuhw5mqFRrcVzcwk+StH13zHCT7xGMsNRKeUe0ac J6WxDAYy7dX6WEb3PALa9WMXHmctrMEdwiWlWmzNs+KBO2LwbUn8WXPYjRblpT4GwiY8 MVnlEr6VAnI9Tg1kM+1x7f23Hj2JpZOH0pMrJGThj2xRrBUnkoxN51rT7E+u7CGsOYmo ROqmrRgbOub92OiE1pRTmvzFkrhfxAbcpb7cir/Zl8pBTziviyhTHXhz7tsUf5kib9G2 A+/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1mILLToEQSFznoisqcOMWl3SJWfi8lRpBkCgUozEfIs=; b=XZxoiwHs1kzB4meqZpSd9vMptaItmPdN6pRib5cTcQcdEW/CwbwUWy5T+FClS2t5WH Krd6WbcyVmFY0/DE8zYa4awSKTXVG8TPqtFl6onkzPv+OkY4dSwf+FXKtBgM6kWwoM+6 CJ0Hbx+YbUuD3h+r/JbP+Vt+4mej+XyOUkxzg137V+PknPemT6iBpWjzUk4HxJelCGnD pahj60cpsMJiUM6Bv6c7cKXxDeA280RY24tFjO+utDE/xyHTamTzMmQOXfNr+EeeI535 pXsMA7DQMZ9EDed084tyncAtfccmAVACjMLYvwlTQSWQRewNdECmFgADVkkjN9JgppEC F/cQ== X-Gm-Message-State: AFqh2kqrrfTrPURMCquUhRjaOdMgMPMCcCIkW3t0TPMKi25Det583NAz 9q/jLyelPlY7ROxMwZWgoFNC7g== X-Google-Smtp-Source: AMrXdXtbriMkJCCnSao5aFgrcC9mn+lvbGzgy0MRyDHtTGIZVN47k0epXGw+oH6iv6qNpzv2YoFV5Q== X-Received: by 2002:a17:902:9b86:b0:194:4b48:f7f1 with SMTP id y6-20020a1709029b8600b001944b48f7f1mr1109091plp.17.1673415559073; Tue, 10 Jan 2023 21:39:19 -0800 (PST) Received: from [192.168.0.115] (63-157-97-90.dia.static.qwest.net. [63.157.97.90]) by smtp.gmail.com with ESMTPSA id v7-20020a1709028d8700b00192902287d1sm8986860plo.288.2023.01.10.21.39.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 21:39:18 -0800 (PST) Message-ID: Date: Tue, 10 Jan 2023 21:39:16 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/2] target/riscv/cpu: set cpu->cfg in register_cpu_props() Content-Language: en-US To: Daniel Henrique Barboza , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com References: <20230110201405.247785-1-dbarboza@ventanamicro.com> <20230110201405.247785-2-dbarboza@ventanamicro.com> From: Richard Henderson In-Reply-To: <20230110201405.247785-2-dbarboza@ventanamicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x631.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/10/23 12:14, Daniel Henrique Barboza wrote: > +/* > + * Register CPU props based on env.misa_ext. If a non-zero > + * value was set, register only the required cpu->cfg.ext_* > + * properties and leave. env.misa_ext = 0 means that we want > + * all the default properties to be registered. > + */ > static void register_cpu_props(DeviceState *dev) Suggest invoking this as .instance_post_init hook on TYPE_RISCV_CPU. Then you don't need to manually call it on every cpu class. r~