From: "Zhang, Chen" <chen.zhang@intel.com>
To: Pan Nengyuan <pannengyuan@huawei.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "kuhn.chenqun@huawei.com" <kuhn.chenqun@huawei.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"zhang.zhanghailiang@huawei.com" <zhang.zhanghailiang@huawei.com>
Subject: RE: [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup
Date: Fri, 4 Sep 2020 15:30:21 +0000 [thread overview]
Message-ID: <cbc8bf62c2d14f78ad21020d50597740@intel.com> (raw)
In-Reply-To: <20200904134908.1396-1-pannengyuan@huawei.com>
> -----Original Message-----
> From: Pan Nengyuan <pannengyuan@huawei.com>
> Sent: Friday, September 4, 2020 9:49 PM
> To: qemu-devel@nongnu.org
> Cc: Zhang, Chen <chen.zhang@intel.com>; jasowang@redhat.com;
> zhang.zhanghailiang@huawei.com; kuhn.chenqun@huawei.com; Pan
> Nengyuan <pannengyuan@huawei.com>
> Subject: [PATCH] net/filter-rewriter: destroy g_hash_table in
> colo_rewriter_cleanup
>
> s->connection_track_table forgot to destroy in colo_rewriter_cleanup. Fix it.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Oh, Thanks Euler Robot~~
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Thanks
Zhang Chen
> ---
> net/filter-rewriter.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c index
> 1aaad101b6..9ff366d44f 100644
> --- a/net/filter-rewriter.c
> +++ b/net/filter-rewriter.c
> @@ -376,6 +376,8 @@ static void colo_rewriter_cleanup(NetFilterState *nf)
> filter_rewriter_flush(nf);
> g_free(s->incoming_queue);
> }
> +
> + g_hash_table_destroy(s->connection_track_table);
> }
>
> static void colo_rewriter_setup(NetFilterState *nf, Error **errp)
> --
> 2.18.2
next prev parent reply other threads:[~2020-09-04 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 13:49 [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup Pan Nengyuan
2020-09-04 15:30 ` Zhang, Chen [this message]
2020-09-05 0:44 ` Li Qiang
2020-10-10 10:54 ` Pan Nengyuan
2020-10-10 16:22 ` Zhang, Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbc8bf62c2d14f78ad21020d50597740@intel.com \
--to=chen.zhang@intel.com \
--cc=jasowang@redhat.com \
--cc=kuhn.chenqun@huawei.com \
--cc=pannengyuan@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).