* [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup
@ 2020-09-04 13:49 Pan Nengyuan
2020-09-04 15:30 ` Zhang, Chen
2020-09-05 0:44 ` Li Qiang
0 siblings, 2 replies; 5+ messages in thread
From: Pan Nengyuan @ 2020-09-04 13:49 UTC (permalink / raw)
To: qemu-devel
Cc: chen.zhang, jasowang, Pan Nengyuan, zhang.zhanghailiang,
kuhn.chenqun
s->connection_track_table forgot to destroy in colo_rewriter_cleanup. Fix it.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
---
net/filter-rewriter.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c
index 1aaad101b6..9ff366d44f 100644
--- a/net/filter-rewriter.c
+++ b/net/filter-rewriter.c
@@ -376,6 +376,8 @@ static void colo_rewriter_cleanup(NetFilterState *nf)
filter_rewriter_flush(nf);
g_free(s->incoming_queue);
}
+
+ g_hash_table_destroy(s->connection_track_table);
}
static void colo_rewriter_setup(NetFilterState *nf, Error **errp)
--
2.18.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup
2020-09-04 13:49 [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup Pan Nengyuan
@ 2020-09-04 15:30 ` Zhang, Chen
2020-09-05 0:44 ` Li Qiang
1 sibling, 0 replies; 5+ messages in thread
From: Zhang, Chen @ 2020-09-04 15:30 UTC (permalink / raw)
To: Pan Nengyuan, qemu-devel@nongnu.org
Cc: kuhn.chenqun@huawei.com, jasowang@redhat.com,
zhang.zhanghailiang@huawei.com
> -----Original Message-----
> From: Pan Nengyuan <pannengyuan@huawei.com>
> Sent: Friday, September 4, 2020 9:49 PM
> To: qemu-devel@nongnu.org
> Cc: Zhang, Chen <chen.zhang@intel.com>; jasowang@redhat.com;
> zhang.zhanghailiang@huawei.com; kuhn.chenqun@huawei.com; Pan
> Nengyuan <pannengyuan@huawei.com>
> Subject: [PATCH] net/filter-rewriter: destroy g_hash_table in
> colo_rewriter_cleanup
>
> s->connection_track_table forgot to destroy in colo_rewriter_cleanup. Fix it.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Oh, Thanks Euler Robot~~
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Thanks
Zhang Chen
> ---
> net/filter-rewriter.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c index
> 1aaad101b6..9ff366d44f 100644
> --- a/net/filter-rewriter.c
> +++ b/net/filter-rewriter.c
> @@ -376,6 +376,8 @@ static void colo_rewriter_cleanup(NetFilterState *nf)
> filter_rewriter_flush(nf);
> g_free(s->incoming_queue);
> }
> +
> + g_hash_table_destroy(s->connection_track_table);
> }
>
> static void colo_rewriter_setup(NetFilterState *nf, Error **errp)
> --
> 2.18.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup
2020-09-04 13:49 [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup Pan Nengyuan
2020-09-04 15:30 ` Zhang, Chen
@ 2020-09-05 0:44 ` Li Qiang
2020-10-10 10:54 ` Pan Nengyuan
1 sibling, 1 reply; 5+ messages in thread
From: Li Qiang @ 2020-09-05 0:44 UTC (permalink / raw)
To: Pan Nengyuan
Cc: Zhang Chen, Jason Wang, Qemu Developers, Chen Qun, zhanghailiang
Pan Nengyuan <pannengyuan@huawei.com> 于2020年9月4日周五 下午3:23写道：
>
> s->connection_track_table forgot to destroy in colo_rewriter_cleanup. Fix it.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> net/filter-rewriter.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c
> index 1aaad101b6..9ff366d44f 100644
> --- a/net/filter-rewriter.c
> +++ b/net/filter-rewriter.c
> @@ -376,6 +376,8 @@ static void colo_rewriter_cleanup(NetFilterState *nf)
> filter_rewriter_flush(nf);
> g_free(s->incoming_queue);
> }
> +
> + g_hash_table_destroy(s->connection_track_table);
> }
>
> static void colo_rewriter_setup(NetFilterState *nf, Error **errp)
> --
> 2.18.2
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup
2020-09-05 0:44 ` Li Qiang
@ 2020-10-10 10:54 ` Pan Nengyuan
2020-10-10 16:22 ` Zhang, Chen
0 siblings, 1 reply; 5+ messages in thread
From: Pan Nengyuan @ 2020-10-10 10:54 UTC (permalink / raw)
To: Li Qiang
Cc: zhanghailiang, qemu-trivial, Jason Wang, Qemu Developers,
Laurent Vivier, Zhang Chen, Chen Qun
ping!
Maybe missed to queue?
On 2020/9/5 8:44, Li Qiang wrote:
> Pan Nengyuan <pannengyuan@huawei.com> 于2020年9月4日周五 下午3:23写道：
>>
>> s->connection_track_table forgot to destroy in colo_rewriter_cleanup. Fix it.
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
>
> Reviewed-by: Li Qiang <liq3ea@gmail.com>
>
>> ---
>> net/filter-rewriter.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c
>> index 1aaad101b6..9ff366d44f 100644
>> --- a/net/filter-rewriter.c
>> +++ b/net/filter-rewriter.c
>> @@ -376,6 +376,8 @@ static void colo_rewriter_cleanup(NetFilterState *nf)
>> filter_rewriter_flush(nf);
>> g_free(s->incoming_queue);
>> }
>> +
>> + g_hash_table_destroy(s->connection_track_table);
>> }
>>
>> static void colo_rewriter_setup(NetFilterState *nf, Error **errp)
>> --
>> 2.18.2
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup
2020-10-10 10:54 ` Pan Nengyuan
@ 2020-10-10 16:22 ` Zhang, Chen
0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Chen @ 2020-10-10 16:22 UTC (permalink / raw)
To: Pan Nengyuan, Li Qiang
Cc: zhanghailiang, qemu-trivial@nongnu.org, Jason Wang,
Laurent Vivier, Qemu Developers, Chen Qun
I already queued this patch to COLO proxy tree, then I will send a series to Jason.
Thanks
Chen
> -----Original Message-----
> From: Pan Nengyuan <pannengyuan@huawei.com>
> Sent: Saturday, October 10, 2020 6:55 PM
> To: Li Qiang <liq3ea@gmail.com>
> Cc: Qemu Developers <qemu-devel@nongnu.org>; Zhang, Chen
> <chen.zhang@intel.com>; Jason Wang <jasowang@redhat.com>;
> zhanghailiang <zhang.zhanghailiang@huawei.com>; Chen Qun
> <kuhn.chenqun@huawei.com>; qemu-trivial@nongnu.org; Laurent Vivier
> <laurent@vivier.eu>
> Subject: Re: [PATCH] net/filter-rewriter: destroy g_hash_table in
> colo_rewriter_cleanup
>
> ping!
>
> Maybe missed to queue?
>
> On 2020/9/5 8:44, Li Qiang wrote:
> > Pan Nengyuan <pannengyuan@huawei.com> 于2020年9月4日周五 下
> 午3:23写道：
> >>
> >> s->connection_track_table forgot to destroy in colo_rewriter_cleanup. Fix
> it.
> >>
> >> Reported-by: Euler Robot <euler.robot@huawei.com>
> >> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
> >
> > Reviewed-by: Li Qiang <liq3ea@gmail.com>
> >
> >> ---
> >> net/filter-rewriter.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c index
> >> 1aaad101b6..9ff366d44f 100644
> >> --- a/net/filter-rewriter.c
> >> +++ b/net/filter-rewriter.c
> >> @@ -376,6 +376,8 @@ static void colo_rewriter_cleanup(NetFilterState
> *nf)
> >> filter_rewriter_flush(nf);
> >> g_free(s->incoming_queue);
> >> }
> >> +
> >> + g_hash_table_destroy(s->connection_track_table);
> >> }
> >>
> >> static void colo_rewriter_setup(NetFilterState *nf, Error **errp)
> >> --
> >> 2.18.2
> >>
> >>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-10 16:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-04 13:49 [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup Pan Nengyuan
2020-09-04 15:30 ` Zhang, Chen
2020-09-05 0:44 ` Li Qiang
2020-10-10 10:54 ` Pan Nengyuan
2020-10-10 16:22 ` Zhang, Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).