From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, vincent.dehors@smile.fr,
alex.bennee@linaro.org, adrien.grassein@smile.fr
Subject: Re: [PATCH 2/4] tests/tcg/aarch64: Fix compilation parameters for pauth-%
Date: Fri, 17 Jan 2020 07:42:23 +0100 [thread overview]
Message-ID: <cbc8fdd9-ddc8-641d-2614-380ffab5d10f@redhat.com> (raw)
In-Reply-To: <20200116230809.19078-3-richard.henderson@linaro.org>
On 1/17/20 12:08 AM, Richard Henderson wrote:
> Hiding the required architecture within asm() is not correct.
> Add it to the cflags of the (cross-) compiler.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tests/tcg/aarch64/pauth-1.c | 2 --
> tests/tcg/aarch64/pauth-2.c | 2 --
> tests/tcg/aarch64/Makefile.target | 1 +
> 3 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/tests/tcg/aarch64/pauth-1.c b/tests/tcg/aarch64/pauth-1.c
> index a3c1443cd0..ea0984ea82 100644
> --- a/tests/tcg/aarch64/pauth-1.c
> +++ b/tests/tcg/aarch64/pauth-1.c
> @@ -2,8 +2,6 @@
> #include <sys/prctl.h>
> #include <stdio.h>
>
> -asm(".arch armv8.4-a");
> -
> #ifndef PR_PAC_RESET_KEYS
> #define PR_PAC_RESET_KEYS 54
> #define PR_PAC_APDAKEY (1 << 2)
> diff --git a/tests/tcg/aarch64/pauth-2.c b/tests/tcg/aarch64/pauth-2.c
> index 2fe030ba3d..9bba0beb63 100644
> --- a/tests/tcg/aarch64/pauth-2.c
> +++ b/tests/tcg/aarch64/pauth-2.c
> @@ -1,8 +1,6 @@
> #include <stdint.h>
> #include <assert.h>
>
> -asm(".arch armv8.4-a");
> -
> void do_test(uint64_t value)
> {
> uint64_t salt1, salt2;
> diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target
> index df3fe8032c..374c8d6830 100644
> --- a/tests/tcg/aarch64/Makefile.target
> +++ b/tests/tcg/aarch64/Makefile.target
> @@ -20,6 +20,7 @@ run-fcvt: fcvt
> # Pauth Tests
> AARCH64_TESTS += pauth-1 pauth-2
> run-pauth-%: QEMU_OPTS += -cpu max
> +pauth-%: CFLAGS += -march=armv8.3-a
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> # Semihosting smoke test for linux-user
> AARCH64_TESTS += semihosting
>
next prev parent reply other threads:[~2020-01-17 6:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 23:08 [PATCH 0/4] target/arm: Fix ComputePAC (LP 1859713) Richard Henderson
2020-01-16 23:08 ` [PATCH 1/4] target/arm: Fix PAuth sbox functions Richard Henderson
2020-01-16 23:08 ` [PATCH 2/4] tests/tcg/aarch64: Fix compilation parameters for pauth-% Richard Henderson
2020-01-17 6:42 ` Philippe Mathieu-Daudé [this message]
2020-01-20 13:10 ` Peter Maydell
2020-01-16 23:08 ` [PATCH 3/4] tests/tcg/aarch64: Add pauth-3 Richard Henderson
2020-01-16 23:08 ` [PATCH 4/4] tests/tcg/aarch64: Add pauth-4 Richard Henderson
2020-01-17 11:41 ` [PATCH 0/4] target/arm: Fix ComputePAC (LP 1859713) no-reply
2020-01-20 13:12 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbc8fdd9-ddc8-641d-2614-380ffab5d10f@redhat.com \
--to=philmd@redhat.com \
--cc=adrien.grassein@smile.fr \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=vincent.dehors@smile.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).