Re: [Qemu-devel] [PATCH v2] block: maintain persistent disabled bitmaps

[Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>]

31.01.2018 22:04, Max Reitz wrote:
> On 2018-01-29 19:43, Max Reitz wrote:
>> On 2018-01-22 11:41, Vladimir Sementsov-Ogievskiy wrote:
>>> To maintain load/store disabled bitmap there is new approach:
>>>
>>>   - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored
>>>   - store enabled bitmaps as "auto" to qcow2
>>>   - store disabled bitmaps without "auto" flag to qcow2
>>>   - on qcow2 open load "auto" bitmaps as enabled and others
>>>     as disabled (except in_use bitmaps)
>>>
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>> Reviewed-by: John Snow <jsnow@redhat.com>
>>> ---
>> Thanks, looks very reasonable.  Applied to my block branch:
>>
>> https://github.com/XanClic/qemu/commits/block
> ...aaand I've only just now seen that iotest 176 will need to be fixed
> along with this, so I'm going to unqueue this patch for now.

ohh, sorry for that. Will resend today.

>
> And when I'm already at it: Should we add deprecation information to
> qemu-doc.texi?

didn't find anything in qemu-doc.texi about dirty bitmaps, so I think, no.

Is there a way to generate some documentation files from qapi comments? 
Where is it?

>
> Max
>



-- 
Best regards,
Vladimir