* [PATCH] hw/i386/acpi-build: Fix a typo
@ 2021-09-08 22:21 Philippe Mathieu-Daudé
2021-09-09 3:58 ` Ani Sinha
2021-09-10 18:54 ` Volker Rümelin
0 siblings, 2 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-08 22:21 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-trivial,
Richard Henderson, Paolo Bonzini, Ani Sinha, Igor Mammedov,
Philippe Mathieu-Daudé
Fix 'hotplugabble' -> 'hotpluggabble' typo.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/i386/acpi-build.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index d1f5fa3b5a5..478263e12c9 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1916,7 +1916,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
PCMachineState *pcms = PC_MACHINE(machine);
int nb_numa_nodes = machine->numa_state->num_nodes;
NodeInfo *numa_info = machine->numa_state->nodes;
- ram_addr_t hotplugabble_address_space_size =
+ ram_addr_t hotpluggabble_address_space_size =
object_property_get_int(OBJECT(pcms), PC_MACHINE_DEVMEM_REGION_SIZE,
NULL);
@@ -2022,10 +2022,10 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
* Memory devices may override proximity set by this entry,
* providing _PXM method if necessary.
*/
- if (hotplugabble_address_space_size) {
+ if (hotpluggabble_address_space_size) {
numamem = acpi_data_push(table_data, sizeof *numamem);
build_srat_memory(numamem, machine->device_memory->base,
- hotplugabble_address_space_size, nb_numa_nodes - 1,
+ hotpluggabble_address_space_size, nb_numa_nodes - 1,
MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED);
}
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] hw/i386/acpi-build: Fix a typo
2021-09-08 22:21 [PATCH] hw/i386/acpi-build: Fix a typo Philippe Mathieu-Daudé
@ 2021-09-09 3:58 ` Ani Sinha
2021-09-10 18:54 ` Volker Rümelin
1 sibling, 0 replies; 8+ messages in thread
From: Ani Sinha @ 2021-09-09 3:58 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-trivial,
Richard Henderson, qemu-devel, Paolo Bonzini, Ani Sinha,
Igor Mammedov
[-- Attachment #1: Type: text/plain, Size: 1673 bytes --]
On Thu, 9 Sep 2021, Philippe Mathieu-Daudé wrote:
> Fix 'hotplugabble' -> 'hotpluggabble' typo.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Ani Sinha <ani@anisinha.ca>
> ---
> hw/i386/acpi-build.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index d1f5fa3b5a5..478263e12c9 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1916,7 +1916,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
> PCMachineState *pcms = PC_MACHINE(machine);
> int nb_numa_nodes = machine->numa_state->num_nodes;
> NodeInfo *numa_info = machine->numa_state->nodes;
> - ram_addr_t hotplugabble_address_space_size =
> + ram_addr_t hotpluggabble_address_space_size =
> object_property_get_int(OBJECT(pcms), PC_MACHINE_DEVMEM_REGION_SIZE,
> NULL);
>
> @@ -2022,10 +2022,10 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
> * Memory devices may override proximity set by this entry,
> * providing _PXM method if necessary.
> */
> - if (hotplugabble_address_space_size) {
> + if (hotpluggabble_address_space_size) {
> numamem = acpi_data_push(table_data, sizeof *numamem);
> build_srat_memory(numamem, machine->device_memory->base,
> - hotplugabble_address_space_size, nb_numa_nodes - 1,
> + hotpluggabble_address_space_size, nb_numa_nodes - 1,
> MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED);
> }
>
> --
> 2.31.1
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] hw/i386/acpi-build: Fix a typo
2021-09-08 22:21 [PATCH] hw/i386/acpi-build: Fix a typo Philippe Mathieu-Daudé
2021-09-09 3:58 ` Ani Sinha
@ 2021-09-10 18:54 ` Volker Rümelin
2021-09-10 19:33 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 8+ messages in thread
From: Volker Rümelin @ 2021-09-10 18:54 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-trivial,
Richard Henderson, qemu-devel, Paolo Bonzini, Ani Sinha,
Igor Mammedov
> Fix 'hotplugabble' -> 'hotpluggabble' typo.
I'm convinced that the correct spelling is hotpluggable. Only the
consonant g is doubled.
With best regards
Volker
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/i386/acpi-build.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index d1f5fa3b5a5..478263e12c9 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1916,7 +1916,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
> PCMachineState *pcms = PC_MACHINE(machine);
> int nb_numa_nodes = machine->numa_state->num_nodes;
> NodeInfo *numa_info = machine->numa_state->nodes;
> - ram_addr_t hotplugabble_address_space_size =
> + ram_addr_t hotpluggabble_address_space_size =
> object_property_get_int(OBJECT(pcms), PC_MACHINE_DEVMEM_REGION_SIZE,
> NULL);
>
> @@ -2022,10 +2022,10 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
> * Memory devices may override proximity set by this entry,
> * providing _PXM method if necessary.
> */
> - if (hotplugabble_address_space_size) {
> + if (hotpluggabble_address_space_size) {
> numamem = acpi_data_push(table_data, sizeof *numamem);
> build_srat_memory(numamem, machine->device_memory->base,
> - hotplugabble_address_space_size, nb_numa_nodes - 1,
> + hotpluggabble_address_space_size, nb_numa_nodes - 1,
> MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED);
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] hw/i386/acpi-build: Fix a typo
2021-09-10 18:54 ` Volker Rümelin
@ 2021-09-10 19:33 ` Philippe Mathieu-Daudé
2021-09-11 1:33 ` Ani Sinha
0 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-10 19:33 UTC (permalink / raw)
To: Volker Rümelin
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-trivial,
Richard Henderson, qemu-devel, Paolo Bonzini, Ani Sinha,
Igor Mammedov
On 9/10/21 8:54 PM, Volker Rümelin wrote:
>> Fix 'hotplugabble' -> 'hotpluggabble' typo.
>
> I'm convinced that the correct spelling is hotpluggable. Only the
> consonant g is doubled.
Lol I missed this part, thanks :>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hw/i386/acpi-build: Fix a typo
2021-09-10 19:33 ` Philippe Mathieu-Daudé
@ 2021-09-11 1:33 ` Ani Sinha
2021-09-11 8:26 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 8+ messages in thread
From: Ani Sinha @ 2021-09-11 1:33 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-trivial,
Volker Rümelin, Richard Henderson, qemu-devel, Paolo Bonzini,
Igor Mammedov
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
On Sat, Sep 11, 2021 at 1:03 AM Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:
> On 9/10/21 8:54 PM, Volker Rümelin wrote:
> >> Fix 'hotplugabble' -> 'hotpluggabble' typo.
> >
> > I'm convinced that the correct spelling is hotpluggable. Only the
> > consonant g is doubled.
>
> Lol I missed this part, thanks :>
Oops my apologies. I also did not notice the double b.
>
>
[-- Attachment #2: Type: text/html, Size: 1029 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hw/i386/acpi-build: Fix a typo
2021-09-11 1:33 ` Ani Sinha
@ 2021-09-11 8:26 ` Philippe Mathieu-Daudé
2021-09-11 9:54 ` Ani Sinha
0 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-11 8:26 UTC (permalink / raw)
To: Ani Sinha
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-trivial,
Volker Rümelin, Richard Henderson, qemu-devel, Paolo Bonzini,
Igor Mammedov
On 9/11/21 3:33 AM, Ani Sinha wrote:
> On Sat, Sep 11, 2021 at 1:03 AM Philippe Mathieu-Daudé
> <philmd@redhat.com <mailto:philmd@redhat.com>> wrote:
>
> On 9/10/21 8:54 PM, Volker Rümelin wrote:
> >> Fix 'hotplugabble' -> 'hotpluggabble' typo.
> >
> > I'm convinced that the correct spelling is hotpluggable. Only the
> > consonant g is doubled.
>
> Lol I missed this part, thanks :>
>
>
> Oops my apologies. I also did not notice the double b.
Typoglycemia++
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hw/i386/acpi-build: Fix a typo
2021-09-11 8:26 ` Philippe Mathieu-Daudé
@ 2021-09-11 9:54 ` Ani Sinha
2021-09-11 11:02 ` Ani Sinha
0 siblings, 1 reply; 8+ messages in thread
From: Ani Sinha @ 2021-09-11 9:54 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-trivial,
Volker Rümelin, Richard Henderson, qemu-devel, Paolo Bonzini,
Igor Mammedov
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
On Sat, Sep 11, 2021 at 13:56 Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:
> On 9/11/21 3:33 AM, Ani Sinha wrote:
> > On Sat, Sep 11, 2021 at 1:03 AM Philippe Mathieu-Daudé
> > <philmd@redhat.com <mailto:philmd@redhat.com>> wrote:
> >
> > On 9/10/21 8:54 PM, Volker Rümelin wrote:
> > >> Fix 'hotplugabble' -> 'hotpluggabble' typo.
> > >
> > > I'm convinced that the correct spelling is hotpluggable. Only the
> > > consonant g is doubled.
> >
> > Lol I missed this part, thanks :>
> >
> >
> > Oops my apologies. I also did not notice the double b.
>
> Typoglycemia++
Will have to experiment with this
https://www.tenderisthebyte.com/blog/2019/06/09/spell-checking-emacs/
[-- Attachment #2: Type: text/html, Size: 1454 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hw/i386/acpi-build: Fix a typo
2021-09-11 9:54 ` Ani Sinha
@ 2021-09-11 11:02 ` Ani Sinha
0 siblings, 0 replies; 8+ messages in thread
From: Ani Sinha @ 2021-09-11 11:02 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Eduardo Habkost, Michael S. Tsirkin, qemu-trivial,
Volker Rümelin, Richard Henderson, qemu-devel, Paolo Bonzini,
Igor Mammedov
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
On Sat, Sep 11, 2021 at 15:24 Ani Sinha <ani@anisinha.ca> wrote:
>
>
> On Sat, Sep 11, 2021 at 13:56 Philippe Mathieu-Daudé <philmd@redhat.com>
> wrote:
>
>> On 9/11/21 3:33 AM, Ani Sinha wrote:
>> > On Sat, Sep 11, 2021 at 1:03 AM Philippe Mathieu-Daudé
>> > <philmd@redhat.com <mailto:philmd@redhat.com>> wrote:
>> >
>> > On 9/10/21 8:54 PM, Volker Rümelin wrote:
>> > >> Fix 'hotplugabble' -> 'hotpluggabble' typo.
>> > >
>> > > I'm convinced that the correct spelling is hotpluggable. Only the
>> > > consonant g is doubled.
>> >
>> > Lol I missed this part, thanks :>
>> >
>> >
>> > Oops my apologies. I also did not notice the double b.
>>
>> Typoglycemia++
>
>
> Will have to experiment with this
>
> https://www.tenderisthebyte.
> <https://www.tenderisthebyte.com/blog/2019/06/09/spell-checking-emacs/>
>
com/blog/2019/06/09/spell-checking-emacs/
> <https://www.tenderisthebyte.com/blog/2019/06/09/spell-checking-emacs/>
>
Maybe we could also add a spellchecker to checkpatch?
[-- Attachment #2: Type: text/html, Size: 2301 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-09-11 11:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-08 22:21 [PATCH] hw/i386/acpi-build: Fix a typo Philippe Mathieu-Daudé
2021-09-09 3:58 ` Ani Sinha
2021-09-10 18:54 ` Volker Rümelin
2021-09-10 19:33 ` Philippe Mathieu-Daudé
2021-09-11 1:33 ` Ani Sinha
2021-09-11 8:26 ` Philippe Mathieu-Daudé
2021-09-11 9:54 ` Ani Sinha
2021-09-11 11:02 ` Ani Sinha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).