From: Richard Henderson <richard.henderson@linaro.org>
To: Bruno Piazera Larsen <bruno.larsen@eldorado.org.br>,
qemu-devel@nongnu.org
Cc: farosas@linux.ibm.com, luis.pires@eldorado.org.br,
lucas.araujo@eldorado.org.br, fernando.valle@eldorado.org.br,
qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br,
david@gibson.dropbear.id.au
Subject: Re: [RFC PATCH 08/11] target/ppc: wrapped some TCG only logic with ifdefs
Date: Mon, 24 May 2021 13:03:14 -0700 [thread overview]
Message-ID: <cc121590-0ff3-fcf4-7356-2ba7259224ac@linaro.org> (raw)
In-Reply-To: <240414de-a246-9878-397e-402a86f70698@eldorado.org.br>
On 5/24/21 11:01 AM, Bruno Piazera Larsen wrote:
>>> +#ifdef CONFIG_TCG
>>> cc->dump_statistics = ppc_cpu_dump_statistics;
>>> +#endif
>>
>> We should just drop this entirely. It's supposedly a generic thing, but only
>> used by ppc. But even then only with source modification to enable
>> DO_PPC_STATISTICS. And even then as we convert to decodetree, said
>> statistics will not be collected.
>>
>> We should delete everything from cpu_dump_statistics on down.
>
> So, now that we have a version of disable-tcg that is functional, I'm inclined
> to look at this cleanup. Just to make sure I got it right: everything related
> to ppc_cpu_dump_statistics and the stuff related to ifdef DO_PPC_STATISTICS can
> be removed, yeah?
I would imagine a set of patches:
(1) DO_PPC_STATISTICS
(2) ppc_cpu_dump_statistics (which will be empty now).
(3) CPUClass.dump_statistics (which now has no setters),
and cpu_dump_statistics (which is closely related).
(4) hmp_info_cpustats (which now does nothing).
r~
next prev parent reply other threads:[~2021-05-24 20:04 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 14:08 [RFC PATCH 00/11] target/ppc: add support to disable-tcg Bruno Larsen (billionai)
2021-05-12 14:08 ` [PATCH 01/11] target/ppc: created ppc_{store, get}_vscr for generic vscr usage Bruno Larsen (billionai)
2021-05-12 16:48 ` [PATCH 01/11] target/ppc: created ppc_{store,get}_vscr " Richard Henderson
2021-05-13 3:48 ` David Gibson
2021-05-12 14:08 ` [PATCH 02/11] target/ppc: moved ppc_store_sdr1 to cpu.c Bruno Larsen (billionai)
2021-05-12 16:54 ` Richard Henderson
2021-05-13 3:50 ` David Gibson
2021-05-31 18:17 ` Bruno Piazera Larsen
2021-06-07 3:50 ` David Gibson
2021-05-12 14:08 ` [PATCH 03/11] target/ppc: moved ppc_cpu_dump_state to cpu_init.c Bruno Larsen (billionai)
2021-05-12 16:58 ` Richard Henderson
2021-05-12 17:00 ` Richard Henderson
2021-05-13 3:51 ` David Gibson
2021-05-12 14:08 ` [PATCH 04/11] target/ppc: moved ppc_store_msr into gdbstub.c Bruno Larsen (billionai)
2021-05-12 17:05 ` Richard Henderson
2021-05-13 3:52 ` David Gibson
2021-05-12 14:08 ` [PATCH 05/11] target/ppc: moved ppc_store_lpcr to cpu.c Bruno Larsen (billionai)
2021-05-12 17:07 ` Richard Henderson
2021-05-13 3:53 ` David Gibson
2021-05-12 14:08 ` [PATCH 06/11] target/ppc: updated vscr manipulation in machine.c Bruno Larsen (billionai)
2021-05-12 17:08 ` Richard Henderson
2021-05-13 3:54 ` David Gibson
2021-05-12 14:08 ` [PATCH 07/11] target/ppc: added KVM fallback to fpscr manipulation Bruno Larsen (billionai)
2021-05-12 18:20 ` Richard Henderson
2021-05-12 19:15 ` Bruno Piazera Larsen
2021-05-13 16:36 ` Bruno Piazera Larsen
2021-05-13 22:45 ` Richard Henderson
2021-05-14 11:12 ` Bruno Piazera Larsen
2021-05-12 14:08 ` [RFC PATCH 08/11] target/ppc: wrapped some TCG only logic with ifdefs Bruno Larsen (billionai)
2021-05-12 18:33 ` Richard Henderson
2021-05-12 18:57 ` Bruno Piazera Larsen
2021-05-14 13:29 ` Bruno Piazera Larsen
2021-05-14 14:44 ` Richard Henderson
2021-05-14 16:22 ` Bruno Piazera Larsen
2021-05-17 4:10 ` David Gibson
2021-05-17 16:07 ` Richard Henderson
2021-05-17 4:00 ` David Gibson
2021-05-24 18:01 ` Bruno Piazera Larsen
2021-05-24 20:03 ` Richard Henderson [this message]
2021-05-12 14:08 ` [PATCH 09/11] include/exec: added functions to the stubs in exec-all.h Bruno Larsen (billionai)
2021-05-12 18:34 ` Richard Henderson
2021-05-13 14:03 ` Lucas Mateus Martins Araujo e Castro
2021-05-13 23:44 ` Richard Henderson
2021-05-17 3:58 ` David Gibson
2021-05-17 16:59 ` Lucas Mateus Martins Araujo e Castro
2021-05-17 18:02 ` Richard Henderson
2021-05-18 18:45 ` Bruno Piazera Larsen
2021-05-24 3:18 ` David Gibson
2021-05-17 3:55 ` David Gibson
2021-05-17 11:07 ` Bruno Piazera Larsen
2021-05-24 3:15 ` David Gibson
2021-05-12 14:08 ` [RFC PATCH 10/11] target/ppc: created tcg-stub.c file Bruno Larsen (billionai)
2021-05-12 18:39 ` Richard Henderson
2021-05-12 19:09 ` Bruno Piazera Larsen
2021-05-14 18:07 ` Bruno Piazera Larsen
2021-05-13 3:59 ` David Gibson
2021-05-13 12:56 ` Bruno Piazera Larsen
2021-05-17 3:53 ` David Gibson
2021-05-12 14:08 ` [PATCH 11/11] target/ppc: updated meson.build to support disable-tcg Bruno Larsen (billionai)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc121590-0ff3-fcf4-7356-2ba7259224ac@linaro.org \
--to=richard.henderson@linaro.org \
--cc=bruno.larsen@eldorado.org.br \
--cc=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=fernando.valle@eldorado.org.br \
--cc=lucas.araujo@eldorado.org.br \
--cc=luis.pires@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).