From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH] Revert "qom: use qemu_printf to print help for user-creatable objects"
Date: Mon, 29 Mar 2021 11:42:53 +0200 [thread overview]
Message-ID: <cc229c1d-09b8-387f-6dbf-68eaa12e1538@redhat.com> (raw)
In-Reply-To: <20210328054758.2351461-1-thuth@redhat.com>
On 28/03/21 07:47, Thomas Huth wrote:
> This reverts commit 6d9abb6de9cc53a508823db0283061824f2f98a2.
>
> The real code change had already been added by Kevin's commit da0a932bbf
> ("hmp: QAPIfy object_add") and commit 6d9abb6d just added a duplicated
> include statement as a left-over of a rebase.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> qom/object_interfaces.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
> index c3324b0f86..b17aa57de1 100644
> --- a/qom/object_interfaces.c
> +++ b/qom/object_interfaces.c
> @@ -17,7 +17,6 @@
> #include "qemu/qemu-print.h"
> #include "qapi/opts-visitor.h"
> #include "qemu/config-file.h"
> -#include "qemu/qemu-print.h"
>
> bool user_creatable_complete(UserCreatable *uc, Error **errp)
> {
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2021-03-29 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 5:47 [PATCH] Revert "qom: use qemu_printf to print help for user-creatable objects" Thomas Huth
2021-03-29 9:42 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc229c1d-09b8-387f-6dbf-68eaa12e1538@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).