Re: [Patch v7 5/5] hw/ppc: Pass errp to load_image_targphys() and report errors

[Aditya Gupta <adityag@linux.ibm.com>]

On 23/10/25 00:57, Vishal Chourasia wrote:

> Pass errp to load_image_targphys() calls in ppc machine initialization
> to capture detailed error information when loading firmware, kernel,
> and initrd images.
>
> Pass error_fatal which automatically reports detailed error messages and
> exits immediately on failure. Eliminating redundant exit(1) calls, as
> error_fatal handles termination

Nitpick: There's no 'errp' now and we aren't capturing error info in 
caller anymore, can replace that with error_fatal.


The patch looks good to me. Will test.


Thanks,

- Aditya G


> The behavior remains functionally identical, but error messages now
> come directly from the loader function with more context about the
> failure cause.
>
> Signed-off-by: Vishal Chourasia <vishalc@linux.ibm.com>
> ---
>   hw/ppc/amigaone.c      | 13 ++-----------
>   hw/ppc/e500.c          | 19 +++----------------
>   hw/ppc/mac_newworld.c  | 16 +++-------------
>   hw/ppc/mac_oldworld.c  | 16 +++-------------
>   hw/ppc/pegasos2.c      |  9 ++-------
>   hw/ppc/pnv.c           | 28 +++++-----------------------
>   hw/ppc/ppc440_bamboo.c |  8 +-------
>   hw/ppc/prep.c          | 17 ++++-------------
>   hw/ppc/sam460ex.c      |  7 +------
>   hw/ppc/spapr.c         | 13 ++-----------
>   hw/ppc/virtex_ml507.c  | 10 ++--------
>   11 files changed, 28 insertions(+), 128 deletions(-)