From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH 7/8] target/rx: Replace MO_TE -> MO_LE
Date: Thu, 9 Oct 2025 10:35:28 -0700 [thread overview]
Message-ID: <cc2764ee-97c1-4451-a49e-f3af41bcfd29@linaro.org> (raw)
In-Reply-To: <20251009151607.26278-8-philmd@linaro.org>
On 10/9/25 08:16, Philippe Mathieu-Daudé wrote:
> We only build the RX targets using little endianness order:
>
> $ git grep TARGET_BIG_ENDIAN configs/targets/rx-*
> $
>
> Therefore the MO_TE definition always expands to MO_LE.
> Use the latter to simplify.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/rx/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/rx/translate.c b/target/rx/translate.c
> index 01a065f937a..c83e7afc60f 100644
> --- a/target/rx/translate.c
> +++ b/target/rx/translate.c
> @@ -74,7 +74,7 @@ static TCGv_i64 cpu_acc;
>
> static inline MemOp mo_endian(DisasContext *dc)
> {
> - return MO_TE;
> + return MO_LE;
> }
>
> /* decoder helper */
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2025-10-09 17:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 15:15 [PATCH 0/8] target/rx: Remove target_ulong and MO_TE uses Philippe Mathieu-Daudé
2025-10-09 15:16 ` [PATCH 1/8] target/rx: Replace target_ulong -> vaddr for translator API uses Philippe Mathieu-Daudé
2025-10-09 17:30 ` Richard Henderson
2025-10-09 15:16 ` [PATCH 2/8] target/rx: Use MemOp type in gen_ld[u]() and gen_st() Philippe Mathieu-Daudé
2025-10-09 17:30 ` Richard Henderson
2025-10-09 15:16 ` [PATCH 3/8] target/rx: Propagate DisasContext to generated helpers Philippe Mathieu-Daudé
2025-10-09 17:32 ` Richard Henderson
2025-10-09 15:16 ` [PATCH 4/8] target/rx: Propagate DisasContext to push() / pop() Philippe Mathieu-Daudé
2025-10-09 17:32 ` Richard Henderson
2025-10-09 15:16 ` [PATCH 5/8] target/rx: Propagate DisasContext to gen_ld[u]() and gen_st() Philippe Mathieu-Daudé
2025-10-09 17:33 ` Richard Henderson
2025-10-09 15:16 ` [PATCH 6/8] target/rx: Factor mo_endian() helper out Philippe Mathieu-Daudé
2025-10-09 17:34 ` Richard Henderson
2025-10-09 15:16 ` [PATCH 7/8] target/rx: Replace MO_TE -> MO_LE Philippe Mathieu-Daudé
2025-10-09 17:35 ` Richard Henderson [this message]
2025-10-09 15:16 ` [PATCH 8/8] target/rx: Expand TCG register definitions for 32-bit target Philippe Mathieu-Daudé
2025-10-09 17:36 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc2764ee-97c1-4451-a49e-f3af41bcfd29@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).