From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A0FFC33CB2 for ; Wed, 15 Jan 2020 13:17:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1809D2084D for ; Wed, 15 Jan 2020 13:17:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dptgOzXi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1809D2084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iriXi-0007OB-7a for qemu-devel@archiver.kernel.org; Wed, 15 Jan 2020 08:17:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55393) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iriWn-0006in-N5 for qemu-devel@nongnu.org; Wed, 15 Jan 2020 08:16:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iriWk-0007hd-Pd for qemu-devel@nongnu.org; Wed, 15 Jan 2020 08:16:08 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:57579 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iriWk-0007h1-La for qemu-devel@nongnu.org; Wed, 15 Jan 2020 08:16:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579094166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uIjkDaB3m7Drix+JBb+7JSwNjXSmbcxRKCoudm3wKO4=; b=dptgOzXi0v3jt3xaWIIPI0IiqAWGTlC/aipl45KUPCEgYLw2UuO07iJmFZNn/FTzulhHLx TgaxsZTgwjd1etMpmhn518dy81onZw4750spp/yOPhu2ct8nU3mJepJM4tUkhoreaJNT5L nwTxixu7xo/FivrjpdHS0G51/AER93A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-340-2-s1A1z0NKaelmA28kmn-Q-1; Wed, 15 Jan 2020 08:16:05 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 75CED800D4C; Wed, 15 Jan 2020 13:16:03 +0000 (UTC) Received: from [10.36.117.108] (ovpn-117-108.ams2.redhat.com [10.36.117.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2E71580890; Wed, 15 Jan 2020 13:15:55 +0000 (UTC) Subject: Re: [PATCH v12 05/13] virtio-iommu: Endpoint and domains structs and helpers To: Peter Xu References: <20200109144319.15912-1-eric.auger@redhat.com> <20200109144319.15912-6-eric.auger@redhat.com> <20200113202301.GD201624@xz-x1> <51267d84-c805-a4a1-8084-b278721a5b3f@redhat.com> <20200114180734.GB225163@xz-x1> From: Auger Eric Message-ID: Date: Wed, 15 Jan 2020 14:15:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20200114180734.GB225163@xz-x1> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 2-s1A1z0NKaelmA28kmn-Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, kevin.tian@intel.com, tnowicki@marvell.com, jean-philippe@linaro.org, quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, bharatb.linux@gmail.com, qemu-arm@nongnu.org, mst@redhat.com, eric.auger.pro@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Peter, On 1/14/20 7:07 PM, Peter Xu wrote: > On Tue, Jan 14, 2020 at 09:51:59AM +0100, Auger Eric wrote: >> Hi Peter, > > Hi, Eric, > > [...] > >>> >>>> +{ >>>> + VirtIOIOMMUEndpoint *ep; >>>> + >>>> + ep = g_tree_lookup(s->endpoints, GUINT_TO_POINTER(ep_id)); >>>> + if (ep) { >>>> + return ep; >>>> + } >>>> + if (!virtio_iommu_mr(s, ep_id)) { >>> >>> Could I ask when this will trigger? >> >> This can happen when a device is attached to a domain and its RID does >> not correspond to one of the devices protected by the iommu. > > So will it happen only because of a kernel driver bug? > > Also, I think the name of "virtio_iommu_mr" is confusing on that it > returned explicitly a MemoryRegion however it's never been used: > > (since they're not in the same patch I'm pasting) > > static IOMMUMemoryRegion *virtio_iommu_mr(VirtIOIOMMU *s, uint32_t sid) > { > uint8_t bus_n, devfn; > IOMMUPciBus *iommu_pci_bus; > IOMMUDevice *dev; > > bus_n = PCI_BUS_NUM(sid); > iommu_pci_bus = iommu_find_iommu_pcibus(s, bus_n); > if (iommu_pci_bus) { > devfn = sid & 0xFF; > dev = iommu_pci_bus->pbdev[devfn]; > if (dev) { > return &dev->iommu_mr; > } > } > return NULL; > } > > Maybe "return !!dev" would be enough, then make the return a boolean? > Then we can rename it to virtio_iommu_has_device(). > > PS. I think we can also drop IOMMU_PCI_DEVFN_MAX (after all you even > didn't use it here!) and use PCI_DEVFN_MAX, and replace 0xFF. Oh yes I can use PCI_DEVFN_MAX directly. Sorry. Eric > > Thanks, >