From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5100DCA0FF6 for ; Wed, 27 Aug 2025 01:24:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ur4sY-0007uz-70; Tue, 26 Aug 2025 21:23:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ur4s2-0007hN-Sp for qemu-devel@nongnu.org; Tue, 26 Aug 2025 21:22:45 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ur4rx-0002MG-3M for qemu-devel@nongnu.org; Tue, 26 Aug 2025 21:22:36 -0400 Received: by mail-pf1-x442.google.com with SMTP id d2e1a72fcca58-76e434a0118so7252367b3a.0 for ; Tue, 26 Aug 2025 18:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756257750; x=1756862550; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=alNXz7XDt+/Gzjz8zwNmt5KRGgSbGDVcngw7hQnNDpw=; b=JNnGvbLV3zqjduIuquGi/rYWzcKA/YT/jl/39tw7RqjsCgYjQMWoQHhd069MT3s4Iw 43CELkKgGR90QghFheq00Amtsm7aiF/TxFlYfymkLTeXwgvGJUoLq45z3ixARnq73KyY 1epGrQs25E54pPWcSls/WfwCCc90MfUNSAxtR2DdY8l7tNYq3StjPqdNSoKPVgYNBZzt 61OhPy69DxKbS60F59nFSdFH203AsZz1MYeNMquMkFBeKhgAIw7HRvAU+aQcIfvAhOqv S7VAHXgET3dQiOht2eJOk6kEeyle618HNELoZmOxRK8RFo3yl+gSCi4fXk8rvoqYhlmt f99w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756257750; x=1756862550; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=alNXz7XDt+/Gzjz8zwNmt5KRGgSbGDVcngw7hQnNDpw=; b=nTH1So7WNjcYgI9gF7GGObi8CbKGbrTq0FgCuVgw1ZW2zWAQT9D/vt40eoSCthNCjR Cv2eRC0OQPtOh+FiqUr7t44QQsRQtsth0iZuwxya+OnY7vMOU9ruKkCAo2ePx+hI5yjR f/t3svqBfPGe+hpuZX7sgmARoLZo/QN1JU68M44gpSXD8d7PlSbvOOmj+3Z0KrUITZ5k s9CDR1iwCaTN03TsAvsQFoCQ7QSjI+j45ekX2EgarKfGNYGbB14SuqvGtRtuon95G9oe U2hAMDjklPkbaJCiSgTpG7n11gz5JGxz+ARrdrgSQIFel2+d7pZGt1/5Vt9tUzcXWxVo VCug== X-Forwarded-Encrypted: i=1; AJvYcCV5N+ZB8HZ8rM4dH7UrRsK9QRJbW4K11X6yVm5d5evEYxZvxzSzHSw3mJI2UqHJu2aSuPwKcOxD5Aq/@nongnu.org X-Gm-Message-State: AOJu0Yxj84RJH3dV/e9psxAntlEmns/T4h1kMnxkBoHQ2RTXx56JFuVB cLQnTHqmZZWWajwuxMmlpU+M2HBqTLm77NJ1LGU+kMqmB7UnVan/QqAWzOibPiqk3isXahMXShm Mm25wpp3fKw== X-Gm-Gg: ASbGncuGImcE03DcYUuMo1DBvOR43VoJnQ4h27ynbpOSlxnIVY0h9bHjE0L7tbVWCLp IInIJolHrSbkykWKRVLM1uYGy9sCu6E9eFJDvXuZw1e2ncP7auEOU3os3VGL99CpqKL5kAb4Jvj /vZfbKpTDQ3ntMmmPsb5llkCcwKw9U0f4EMiq+UTnIQblO8CE5fsgGeTegEexfBx56j4DblzzVu mI65tMBeLTjVI4dphTKKR5JyStJ1y0ZIu4SgSoZhy0zsGwrpheYFnijDQHSB7ePmQgsXbAeIzZ8 BMrfmYkmFo0Vv6/4WAVgssJ0U48lsveXMe8LcTIQHKqjlBTsw1VYpfP1tE4ZMA8QzItnFQaR3Q0 2ImiunUNlAZgq9fx7fCHbTTetGgR5UyjZ8BWW6FrTkmLW X-Google-Smtp-Source: AGHT+IHmP409bB6GGaRifw/UT06Hfps1X7a+8+q3HSJRA6DuR8A7QcmKSR//t2yS4AYWfoCr+YjcUQ== X-Received: by 2002:a05:6a00:190e:b0:758:66a2:981f with SMTP id d2e1a72fcca58-7702fa0590emr24716778b3a.12.1756257749601; Tue, 26 Aug 2025 18:22:29 -0700 (PDT) Received: from [192.168.0.102] ([187.75.38.174]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-771e93ec6fasm6071979b3a.31.2025.08.26.18.22.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Aug 2025 18:22:29 -0700 (PDT) Message-ID: Date: Tue, 26 Aug 2025 22:23:11 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] tests/functional: Adapt reverse_debugging to run w/o Avocado To: Thomas Huth , qemu-devel@nongnu.org, alex.bennee@linaro.org Cc: qemu-arm@nongnu.org, "Daniel P. Berrange" References: <20250819143916.4138035-1-gustavo.romero@linaro.org> <20250819143916.4138035-5-gustavo.romero@linaro.org> <2ef8923b-18f5-47c6-b688-c9fa5b4fb0e4@redhat.com> Content-Language: en-US From: Gustavo Romero In-Reply-To: <2ef8923b-18f5-47c6-b688-c9fa5b4fb0e4@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=gustavo.romero@linaro.org; helo=mail-pf1-x442.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Thomas, On 8/25/25 07:34, Thomas Huth wrote: > On 19/08/2025 16.39, Gustavo Romero wrote: >> This commit removes Avocado as a dependency for running the >> reverse_debugging test. >> >> The main benefit, beyond eliminating an extra dependency, is that there >> is no longer any need to handle GDB packets manually. This removes the >> need for ad-hoc functions dealing with endianness and arch-specific >> register numbers, making the test easier to read. The timeout variable >> is also removed, since Meson now manages timeouts automatically. >> >> The reverse_debugging test is now executed through a runner, because it >> requires GDB in addition to QMP. The runner is responsible for invoking >> GDB with the appropriate arguments and for passing the test script to >> GDB. >> >> Since the test now runs inside GDB, its output, particularly from >> 'stepi' commands, which cannot be disabled, interleaves with the TAP >> output from unittest. To avoid this conflict, the test no longer uses >> Meson’s 'tap' protocol and instead relies on the simpler 'exitcode' >> protocol. >> >> reverse_debugging is kept "skipped" for aarch64, ppc64, and x86_64, so >> won't run unless QEMU_TEST_FLAKY_TESTS=1 is set in the test environment, >> before running 'make check-functional' or 'meson test [...]'. >> >> Signed-off-by: Gustavo Romero >> --- > ... >> diff --git a/tests/functional/test_aarch64_reverse_debug.py b/tests/functional/test_aarch64_reverse_debug.py >> index 58d4532835..8b6f82c227 100755 >> --- a/tests/functional/test_aarch64_reverse_debug.py >> +++ b/tests/functional/test_aarch64_reverse_debug.py > ... >> -    KERNEL_ASSET = Asset( >> +    ASSET_KERNEL = Asset( >>           ('https://archives.fedoraproject.org/pub/archive/fedora/linux/' >>            'releases/29/Everything/aarch64/os/images/pxeboot/vmlinuz'), >>           '7e1430b81c26bdd0da025eeb8fbd77b5dc961da4364af26e771bd39f379cbbf7') >> @@ -30,9 +29,9 @@ class ReverseDebugging_AArch64(ReverseDebugging): >>       def test_aarch64_virt(self): >>           self.set_machine('virt') >>           self.cpu = 'cortex-a53' >> -        kernel_path = self.KERNEL_ASSET.fetch() >> +        kernel_path = self.ASSET_KERNEL.fetch() >>           self.reverse_debugging(args=('-kernel', kernel_path)) > > Ouch, that "KERNEL_ASSET" is worth to be sent as a separate bugfix (without the proper "ASSET_" prefix, the asset won't be precached properly). Could you maybe send this as a separate patch, please? Post here: https://lists.gnu.org/archive/html/qemu-devel/2025-08/msg03763.html Cheers, Gustavo