qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Milan Zamazal <mzamazal@redhat.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com, stefanha@redhat.com, alex.bennee@linaro.org
Subject: Re: [PATCH 3/4] tests/qtest: Fix a comment typo in vhost-user-test.c
Date: Wed, 31 May 2023 07:02:24 +0200	[thread overview]
Message-ID: <cc482875-6007-466d-808a-fc3ddec2a659@redhat.com> (raw)
In-Reply-To: <89d88ee1cab67b8412617e593ea786f1014d737b.1685476786.git.mzamazal@redhat.com>

On 24/05/2023 15.34, Milan Zamazal wrote:
> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
> ---
>   tests/qtest/vhost-user-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
> index e4f95b2858..8ab10732f8 100644
> --- a/tests/qtest/vhost-user-test.c
> +++ b/tests/qtest/vhost-user-test.c
> @@ -281,7 +281,7 @@ static void read_guest_mem_server(QTestState *qts, TestServer *s)
>       /* iterate all regions */
>       for (i = 0; i < s->fds_num; i++) {
>   
> -        /* We'll check only the region statring at 0x0*/
> +        /* We'll check only the region starting at 0x0*/

While you're at it, I'd also add a space between the "0x0" and the "*/".

Anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>

>           if (s->memory.regions[i].guest_phys_addr != 0x0) {
>               continue;
>           }



  reply	other threads:[~2023-05-31  5:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 19:59 [PATCH 0/4] Add SCMI vhost-user VIRTIO device Milan Zamazal
2023-05-23  8:02 ` [PATCH 1/4] hw/virtio: Add boilerplate for vhost-user-scmi device Milan Zamazal
2023-05-23  8:19 ` [PATCH 2/4] hw/virtio: Add vhost-user-scmi-pci boilerplate Milan Zamazal
2023-05-23 14:38 ` [PATCH 4/4] tests/qtest: enable tests for virtio-scmi Milan Zamazal
2023-05-31  5:05   ` Thomas Huth
2023-05-24 13:34 ` [PATCH 3/4] tests/qtest: Fix a comment typo in vhost-user-test.c Milan Zamazal
2023-05-31  5:02   ` Thomas Huth [this message]
2023-05-31 11:06     ` Milan Zamazal
2023-05-31 11:19 ` [PATCH 0/4] Add SCMI vhost-user VIRTIO device Alex Bennée
2023-05-31 11:57   ` Milan Zamazal
2023-05-31 12:48     ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc482875-6007-466d-808a-fc3ddec2a659@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=mst@redhat.com \
    --cc=mzamazal@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).