From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8054CC76192 for ; Tue, 16 Jul 2019 15:58:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C48D20880 for ; Tue, 16 Jul 2019 15:58:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C48D20880 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnPr0-0006mx-MA for qemu-devel@archiver.kernel.org; Tue, 16 Jul 2019 11:58:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42187) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnPqp-0006HV-Aa for qemu-devel@nongnu.org; Tue, 16 Jul 2019 11:58:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnPqo-0006OO-3A for qemu-devel@nongnu.org; Tue, 16 Jul 2019 11:58:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57144) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hnPql-0006Mh-Fz; Tue, 16 Jul 2019 11:58:43 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C666830C34C2; Tue, 16 Jul 2019 15:58:42 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.205.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B3FA81001B0D; Tue, 16 Jul 2019 15:58:40 +0000 (UTC) To: Eric Blake , Thomas Huth , qemu-devel@nongnu.org References: <20190716122836.31187-1-thuth@redhat.com> <20190716122836.31187-3-thuth@redhat.com> <1832e90b-0fd2-19ac-f90e-572147e51f53@redhat.com> <62ec1243-3bb9-c18d-0ff6-4c4ad193620c@redhat.com> <03b260f7-b108-f035-2974-17b5ef74e4e6@redhat.com> <99ee850e-d9e0-1079-7fb2-64a1901009e6@redhat.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Tue, 16 Jul 2019 17:58:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <99ee850e-d9e0-1079-7fb2-64a1901009e6@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OLJHF4i1aQvciCf8gcNqyS37GRspwAEsN" X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 16 Jul 2019 15:58:42 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 2/4] tests/qemu-iotests/group: Remove some more tests from the "auto" group X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OLJHF4i1aQvciCf8gcNqyS37GRspwAEsN Content-Type: multipart/mixed; boundary="3VldiOMoviXIV4uFH6iM42N2ZO2pmLGgQ"; protected-headers="v1" From: Max Reitz To: Eric Blake , Thomas Huth , qemu-devel@nongnu.org Cc: Kevin Wolf , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-block@nongnu.org Message-ID: Subject: Re: [PATCH v2 2/4] tests/qemu-iotests/group: Remove some more tests from the "auto" group References: <20190716122836.31187-1-thuth@redhat.com> <20190716122836.31187-3-thuth@redhat.com> <1832e90b-0fd2-19ac-f90e-572147e51f53@redhat.com> <62ec1243-3bb9-c18d-0ff6-4c4ad193620c@redhat.com> <03b260f7-b108-f035-2974-17b5ef74e4e6@redhat.com> <99ee850e-d9e0-1079-7fb2-64a1901009e6@redhat.com> In-Reply-To: <99ee850e-d9e0-1079-7fb2-64a1901009e6@redhat.com> --3VldiOMoviXIV4uFH6iM42N2ZO2pmLGgQ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 16.07.19 17:56, Eric Blake wrote: > On 7/16/19 10:44 AM, Max Reitz wrote: >> On 16.07.19 17:31, Thomas Huth wrote: >>> On 16/07/2019 17.26, Max Reitz wrote: >>>> On 16.07.19 14:28, Thomas Huth wrote: >>>>> Remove some more tests from the "auto" group that either have issue= s >>>>> in certain environments (like macOS or FreeBSD, or on certain file = systems >>>>> like ZFS or tmpfs), do not work with the qcow2 format, or that are = simply >>>>> taking too much time. >>>>> >>>>> Signed-off-by: Thomas Huth >>>>> --- >>>>> tests/qemu-iotests/group | 114 ++++++++++++++++++++---------------= ---- >>>>> 1 file changed, 58 insertions(+), 56 deletions(-) >>>> >>>> I just looked through the list to see whether any of the test seems = like >>>> we=E2=80=99d want to keep it even though it is a bit slow. Mostly I= was looking >>>> for tests that cover complex cases. >>>> >>>> 255 is the only one that seemed to fit that bill to me. So why do y= ou >>>> remove it? Is it because it takes two seconds? >>> >>> No, I removed it because it was failing on macOS: >>> >>> https://cirrus-ci.com/task/4860239294234624 >>> >>> ("OSError: AF_UNIX path too long" is the error, if I got that right) >> >> Ah, OK. So, uh, we effectively can=E2=80=99t run any Python tests on = macOS? >=20 > Not when our CI is set up to use super-long file names: >=20 > + File > "/private/var/folders/sy/2x5qvs0n4lg18fry9jz4y21m0000gn/T/cirrus-ci-bui= ld/tests/qemu-iotests/../../python/qemu/machine.py", > line 294, in launch That isn=E2=80=99t really long. > Is there any way to create our sockets somewhere under /tmp instead of > inside tests/qemu-iotests, so that we have a shorter filename for > sockets no matter how deep in the file hierarchy the tests themselves l= ive? >=20 > Also, at one point, we tossed around the idea of > s/qemu-iotests/iotests/, to shave off 5 characters that don't really ad= d > anything. I=E2=80=99d personally rather just skip the iotests if we detect such a s= illy OS, but maybe that=E2=80=99s just me. Max --3VldiOMoviXIV4uFH6iM42N2ZO2pmLGgQ-- --OLJHF4i1aQvciCf8gcNqyS37GRspwAEsN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl0t9C4ACgkQ9AfbAGHV z0CddggAqLVfgFqSHflAtoAallWy5MIxgEKkHiVMVSkQlJGCl9YK/rWqVRdp/K+b SFmhaWuCh4uUXSUhcXsNCBtx1pBqj7PS6xUNq2Z/y++Tjkuu2vrqXEZTq/oAqYyT odTllxgQPVWN7hXcBcXolTdfbNvuVjRzbsexfAfVx6xhag9DWl/RaFFBVA8cJl1o t0pSnvTQvhzgR1GjI3Hxq97EpAulP1eWGjrsbDHCZWx41ZLZxCCzVEOikb3mapx6 DsfdVSKukSS0elWC7/hE+yGwVQ4W5ZPghkyvq31SksIQuNEOqjRHw7TrVPfrmCOD RU4yVA0+kqCO195b69JjhtUTstLCdw== =Z91V -----END PGP SIGNATURE----- --OLJHF4i1aQvciCf8gcNqyS37GRspwAEsN--