From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"David Gibson" <david@gibson.dropbear.id.au>
Cc: qemu-trivial@nongnu.org,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>,
qemu-ppc@nongnu.org, "Artyom Tarasenko" <atar4qemu@gmail.com>
Subject: Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()
Date: Thu, 24 Sep 2020 17:00:21 +0200 [thread overview]
Message-ID: <cc4d5239-636c-f01a-d822-97ea60ee303c@vivier.eu> (raw)
In-Reply-To: <de2b5d0c-fcc4-a26c-5fda-610b7fa75862@amsat.org>
Le 24/09/2020 à 16:53, Philippe Mathieu-Daudé a écrit :
> On 9/16/20 4:50 AM, David Gibson wrote:
>> On Mon, Sep 14, 2020 at 12:24:25PM +0200, Philippe Mathieu-Daudé wrote:
>>> As the 'io_base' argument of m48t59_init() is unused (set to 0),
>>> remove it to simplify.
>>> To create a device on the ISA bus, m48t59_init_isa() is the
>>> preferred function to use.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> include/hw/rtc/m48t59.h | 2 +-
>>> hw/ppc/ppc405_boards.c | 2 +-
>>> hw/rtc/m48t59.c | 10 ++--------
>>> hw/sparc/sun4m.c | 2 +-
>>> hw/sparc64/sun4u.c | 2 +-
>>> 5 files changed, 6 insertions(+), 12 deletions(-)
>>
>> ppc part
>> Acked-by: David Gibson <david@gibson.dropbear.id.au>
>
> Thanks!
>
> Can this go via qemu-trivial@?
Yes, but more reviewers would help. Mark?
Thanks,
Laurent
next prev parent reply other threads:[~2020-09-24 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 10:24 [PATCH] hw/rtc/m48t59: Simplify m48t59_init() Philippe Mathieu-Daudé
2020-09-16 2:50 ` David Gibson
2020-09-24 14:53 ` Philippe Mathieu-Daudé
2020-09-24 15:00 ` Laurent Vivier [this message]
2020-09-29 10:21 ` Philippe Mathieu-Daudé
2020-09-30 8:26 ` Mark Cave-Ayland
2020-09-30 8:35 ` Mark Cave-Ayland
2020-09-30 10:22 ` Philippe Mathieu-Daudé
2020-09-30 11:25 ` Laurent Vivier
2020-10-12 21:18 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc4d5239-636c-f01a-d822-97ea60ee303c@vivier.eu \
--to=laurent@vivier.eu \
--cc=atar4qemu@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=hpoussin@reactos.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).