* [PATCH] linux-user: Use EPROTONOSUPPORT for unimplemented netlink protocols
@ 2020-07-07 0:10 Josh Kunz
2020-07-07 9:46 ` Laurent Vivier
2020-07-13 18:49 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Josh Kunz @ 2020-07-07 0:10 UTC (permalink / raw)
To: qemu-devel; +Cc: riku.voipio, laurent, Josh Kunz
Linux uses the EPROTONOSUPPORT error code[1] if the users requests a
netlink socket with an unsupported netlink protocol. This change
switches linux-user to use the same code as Linux, instead of
EPFNOSUPPORT (which AFAIK is just an anachronistic version of
EAFNOSUPPORT).
Tested by compiling all linux-user targets on x86.
[1]:
https://github.com/torvalds/linux/blob/bfe91da29bfad9941d5d703d45e29f0812a20724/net/netlink/af_netlink.c#L683
Signed-off-by: Josh Kunz <jkz@google.com>
---
linux-user/syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 97de9fb5c9..4ab9852600 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2987,7 +2987,7 @@ static abi_long do_socket(int domain, int type, int protocol)
#endif
protocol == NETLINK_KOBJECT_UEVENT ||
protocol == NETLINK_AUDIT)) {
- return -TARGET_EPFNOSUPPORT;
+ return -TARGET_EPROTONOSUPPORT;
}
if (domain == AF_PACKET ||
--
2.27.0.212.ge8ba1cc988-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] linux-user: Use EPROTONOSUPPORT for unimplemented netlink protocols
2020-07-07 0:10 [PATCH] linux-user: Use EPROTONOSUPPORT for unimplemented netlink protocols Josh Kunz
@ 2020-07-07 9:46 ` Laurent Vivier
2020-07-13 18:49 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-07-07 9:46 UTC (permalink / raw)
To: Josh Kunz, qemu-devel; +Cc: riku.voipio
Le 07/07/2020 à 02:10, Josh Kunz a écrit :
> Linux uses the EPROTONOSUPPORT error code[1] if the users requests a
> netlink socket with an unsupported netlink protocol. This change
> switches linux-user to use the same code as Linux, instead of
> EPFNOSUPPORT (which AFAIK is just an anachronistic version of
> EAFNOSUPPORT).
>
> Tested by compiling all linux-user targets on x86.
>
> [1]:
> https://github.com/torvalds/linux/blob/bfe91da29bfad9941d5d703d45e29f0812a20724/net/netlink/af_netlink.c#L683
>
> Signed-off-by: Josh Kunz <jkz@google.com>
> ---
> linux-user/syscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 97de9fb5c9..4ab9852600 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -2987,7 +2987,7 @@ static abi_long do_socket(int domain, int type, int protocol)
> #endif
> protocol == NETLINK_KOBJECT_UEVENT ||
> protocol == NETLINK_AUDIT)) {
> - return -TARGET_EPFNOSUPPORT;
> + return -TARGET_EPROTONOSUPPORT;
> }
>
> if (domain == AF_PACKET ||
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] linux-user: Use EPROTONOSUPPORT for unimplemented netlink protocols
2020-07-07 0:10 [PATCH] linux-user: Use EPROTONOSUPPORT for unimplemented netlink protocols Josh Kunz
2020-07-07 9:46 ` Laurent Vivier
@ 2020-07-13 18:49 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-07-13 18:49 UTC (permalink / raw)
To: Josh Kunz, qemu-devel; +Cc: riku.voipio
Le 07/07/2020 à 02:10, Josh Kunz a écrit :
> Linux uses the EPROTONOSUPPORT error code[1] if the users requests a
> netlink socket with an unsupported netlink protocol. This change
> switches linux-user to use the same code as Linux, instead of
> EPFNOSUPPORT (which AFAIK is just an anachronistic version of
> EAFNOSUPPORT).
>
> Tested by compiling all linux-user targets on x86.
>
> [1]:
> https://github.com/torvalds/linux/blob/bfe91da29bfad9941d5d703d45e29f0812a20724/net/netlink/af_netlink.c#L683
>
> Signed-off-by: Josh Kunz <jkz@google.com>
> ---
> linux-user/syscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 97de9fb5c9..4ab9852600 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -2987,7 +2987,7 @@ static abi_long do_socket(int domain, int type, int protocol)
> #endif
> protocol == NETLINK_KOBJECT_UEVENT ||
> protocol == NETLINK_AUDIT)) {
> - return -TARGET_EPFNOSUPPORT;
> + return -TARGET_EPROTONOSUPPORT;
> }
>
> if (domain == AF_PACKET ||
>
Applied to my linux-user-for-5.1 branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-13 18:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-07 0:10 [PATCH] linux-user: Use EPROTONOSUPPORT for unimplemented netlink protocols Josh Kunz
2020-07-07 9:46 ` Laurent Vivier
2020-07-13 18:49 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).