From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mis8M-0001c5-3j for qemu-devel@nongnu.org; Wed, 02 Sep 2009 11:52:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mis8L-0001bQ-AA for qemu-devel@nongnu.org; Wed, 02 Sep 2009 11:52:29 -0400 Received: from [199.232.76.173] (port=40846 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mis8L-0001bA-45 for qemu-devel@nongnu.org; Wed, 02 Sep 2009 11:52:29 -0400 Received: from fg-out-1718.google.com ([72.14.220.157]:25835) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mis8K-0004C0-Jl for qemu-devel@nongnu.org; Wed, 02 Sep 2009 11:52:28 -0400 Received: by fg-out-1718.google.com with SMTP id e21so1074484fga.10 for ; Wed, 02 Sep 2009 08:52:27 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <87pra9ic2p.fsf@lechat.rtp-net.org> References: <1251904883-13706-1-git-send-email-kirill@shutemov.name> <1251904883-13706-2-git-send-email-kirill@shutemov.name> <87pra9ic2p.fsf@lechat.rtp-net.org> Date: Wed, 2 Sep 2009 18:52:26 +0300 Message-ID: Subject: Re: [Qemu-devel] [PATCH 2/2] Build *-user targets as PIE From: "Kirill A. Shutemov" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Arnaud Patard Cc: qemu-devel@nongnu.org On Wed, Sep 2, 2009 at 6:46 PM, Arnaud Patard wr= ote: > "Kirill A. Shutemov" writes: > > Hi, > > [...] > >> diff --git a/configure b/configure >> index 0d0162a..b501526 100755 >> --- a/configure >> +++ b/configure >> @@ -2302,6 +2302,11 @@ if test "$target_softmmu" =3D "yes" ; then >> =C2=A0 =C2=A0esac >> =C2=A0fi >> >> +if test "$target_user_only" =3D "yes" -a "$static" =3D "no" ; then >> + =C2=A0cflags=3D"-fpie $cflags" >> + =C2=A0ldflags=3D"-pie $ldflags" >> +fi >> + > > Please do that on per-arch basis. For instance, pie support tends to > be broken quite often on mips (afaik, it's currently broken on debian > unstable). I know qemu doesn't support mips host but it doesn't mean it > will never be supported - I need to find time to update to current git > and fix remaining bugs in my code before sending it for merge. > Unfortunately, this kind of patch will make sure it won't happen soon :( > > > Thanks, > Arnaud > Will you happy if I provide option like --disable-user-pie to configure? P.S. Sorry I forgot to put qemu-devil into CC.