From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKdNQ-000350-8h
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 14:48:08 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKdNL-0002wS-1a
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 14:48:07 -0500
Received: from [199.232.76.173] (port=35051 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKdNK-0002wB-SO
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 14:48:02 -0500
Received: from mail-fx0-f222.google.com ([209.85.220.222]:38538)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kirill@shutemov.name>) id 1NKdNK-0001hI-Fc
	for qemu-devel@nongnu.org; Tue, 15 Dec 2009 14:48:02 -0500
Received: by fxm22 with SMTP id 22so252515fxm.2
	for <qemu-devel@nongnu.org>; Tue, 15 Dec 2009 11:48:01 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1260839404-28622-1-git-send-email-kirill@shutemov.name>
References: <1260839404-28622-1-git-send-email-kirill@shutemov.name>
Date: Tue, 15 Dec 2009 21:48:00 +0200
Message-ID: <cc557aab0912151148v2a98d2b2n7dd67fdb23388cd6@mail.gmail.com>
From: "Kirill A. Shutemov" <kirill@shutemov.name>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] Fix TEXTREL in user targets when compiled
	with --enable-user-pie
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, "Kirill A. Shutemov" <kirill@shutemov.name>

Please, apply it.

On Tue, Dec 15, 2009 at 3:10 AM, Kirill A. Shutemov
<kirill@shutemov.name> wrote:
> We really need compile _all_ sources for user target with -fpie when
> use --enable-user-pie.
>
> It's regression introduced by commit add16157d72454.
> Please, do not break it any more.
>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> ---
> =C2=A0Makefile.user | =C2=A0 =C2=A04 ++--
> =C2=A0configure =C2=A0 =C2=A0 | =C2=A0 =C2=A01 +
> =C2=A02 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile.user b/Makefile.user
> index 907e74b..0be73df 100644
> --- a/Makefile.user
> +++ b/Makefile.user
> @@ -5,9 +5,9 @@ include $(SRC_PATH)/rules.mak
>
> =C2=A0.PHONY: all
>
> -VPATH=3D$(SRC_PATH)
> +vpath %.c $(SRC_PATH)
>
> -QEMU_CFLAGS+=3D-I..
> +QEMU_CFLAGS+=3D-I$(SRC_PATH)/ $(CFLAGS_PIE)
>
> =C2=A0obj-y =3D
> =C2=A0obj-y +=3D envlist.o path.o
> diff --git a/configure b/configure
> index 273b6b7..6200391 100755
> --- a/configure
> +++ b/configure
> @@ -2555,6 +2555,7 @@ if test "$target_user_only" =3D "yes" -a "$static" =
=3D "no" -a \
> =C2=A0 =C2=A0 =C2=A0 =C2=A0"$user_pie" =3D "yes" ; then
> =C2=A0 cflags=3D"-fpie $cflags"
> =C2=A0 ldflags=3D"-pie $ldflags"
> + =C2=A0echo "CFLAGS_PIE=3D-fpie" >> $config_host_mak
> =C2=A0fi
>
> =C2=A0if test "$target_softmmu" =3D "yes" -a \( \
> --
> 1.6.5.6
>
>