From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] Fix TEXTREL in user targets when compiled with --enable-user-pie
Date: Wed, 16 Dec 2009 11:25:19 +0200 [thread overview]
Message-ID: <cc557aab0912160125s1660a9fbh6f621c99a61202a1@mail.gmail.com> (raw)
In-Reply-To: <hga8er$7fd$1@ger.gmane.org>
On Wed, Dec 16, 2009 at 11:15 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 12/16/2009 09:45 AM, Kirill A. Shutemov wrote:
>>>>>
>>>>> >>> -VPATH=$(SRC_PATH)
>>>>> >>> +vpath %.c $(SRC_PATH)
>>>
>>> >
>>> > This change is needed?
>>
>> Yes. We dont want to take %.o from $(SRC_PATH) since they built without
>> -fpie.
>
> I think that's fine, it's kind of the purpose of vpath to only look for
> sources in the vpath; so it's safer to use "vpath" than "VPATH". That said,
> I'd change it to
>
> vpath %.c %.h $(SRC_PATH)
We don't have make-targets which require %.h in Makefile.user, so it's noise.
>
> and I'd do so uniformly in all the directories that currently use VPATH.
>
> Paolo
>
>
>
>
next prev parent reply other threads:[~2009-12-16 9:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 1:10 [Qemu-devel] [PATCH] Fix TEXTREL in user targets when compiled with --enable-user-pie Kirill A. Shutemov
2009-12-15 19:48 ` [Qemu-devel] " Kirill A. Shutemov
2009-12-15 20:55 ` Juan Quintela
2009-12-16 8:45 ` Kirill A. Shutemov
2009-12-16 9:15 ` Paolo Bonzini
2009-12-16 9:25 ` Kirill A. Shutemov [this message]
2009-12-16 10:06 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc557aab0912160125s1660a9fbh6f621c99a61202a1@mail.gmail.com \
--to=kirill@shutemov.name \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).