From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKq8L-0001pM-00
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 04:25:25 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKq8G-0001jU-H3
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 04:25:24 -0500
Received: from [199.232.76.173] (port=46237 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKq8G-0001jM-9n
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 04:25:20 -0500
Received: from mail-gx0-f223.google.com ([209.85.217.223]:47573)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kirill@shutemov.name>) id 1NKq8F-0000WK-Vb
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 04:25:20 -0500
Received: by gxk23 with SMTP id 23so860592gxk.2
	for <qemu-devel@nongnu.org>; Wed, 16 Dec 2009 01:25:19 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <hga8er$7fd$1@ger.gmane.org>
References: <1260839404-28622-1-git-send-email-kirill@shutemov.name>
	<cc557aab0912151148v2a98d2b2n7dd67fdb23388cd6@mail.gmail.com>
	<m36388neii.fsf@neno.neno>
	<cc557aab0912160045l312a9554sbf9fc56372ed1a05@mail.gmail.com>
	<hga8er$7fd$1@ger.gmane.org>
Date: Wed, 16 Dec 2009 11:25:19 +0200
Message-ID: <cc557aab0912160125s1660a9fbh6f621c99a61202a1@mail.gmail.com>
Subject: Re: [Qemu-devel] Re: [PATCH] Fix TEXTREL in user targets when
	compiled with --enable-user-pie
From: "Kirill A. Shutemov" <kirill@shutemov.name>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Dec 16, 2009 at 11:15 AM, Paolo Bonzini <pbonzini@redhat.com> wrote=
:
> On 12/16/2009 09:45 AM, Kirill A. Shutemov wrote:
>>>>>
>>>>> >>> =C2=A0-VPATH=3D$(SRC_PATH)
>>>>> >>> =C2=A0+vpath %.c $(SRC_PATH)
>>>
>>> >
>>> > =C2=A0This change is needed?
>>
>> Yes. We dont want to take %.o from $(SRC_PATH) since they built without
>> -fpie.
>
> I think that's fine, it's kind of the purpose of vpath to only look for
> sources in the vpath; so it's safer to use "vpath" than "VPATH". =C2=A0Th=
at said,
> I'd change it to
>
> vpath %.c %.h $(SRC_PATH)

We don't have make-targets which require %.h in Makefile.user, so it's nois=
e.

>
> and I'd do so uniformly in all the directories that currently use VPATH.
>
> Paolo
>
>
>
>