From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSBwl-0006Y0-9f
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 11:07:51 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSBwg-0006RA-LB
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 11:07:49 -0500
Received: from [199.232.76.173] (port=50767 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSBwe-0006QW-P1
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 11:07:44 -0500
Received: from mail-ew0-f221.google.com ([209.85.219.221]:48566)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kirill@shutemov.name>) id 1NSBwc-00025g-Nt
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 11:07:44 -0500
Received: by ewy21 with SMTP id 21so8883002ewy.2
	for <qemu-devel@nongnu.org>; Tue, 05 Jan 2010 08:07:35 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <m3zl4svci4.fsf@neno.neno>
References: <1262403933-26881-1-git-send-email-kirill@shutemov.name>
	<1262403933-26881-2-git-send-email-kirill@shutemov.name>
	<1262403933-26881-3-git-send-email-kirill@shutemov.name>
	<1262403933-26881-4-git-send-email-kirill@shutemov.name>
	<1262403933-26881-5-git-send-email-kirill@shutemov.name>
	<1262403933-26881-6-git-send-email-kirill@shutemov.name>
	<1262403933-26881-7-git-send-email-kirill@shutemov.name>
	<1262403933-26881-8-git-send-email-kirill@shutemov.name>
	<1262403933-26881-9-git-send-email-kirill@shutemov.name>
	<m3zl4svci4.fsf@neno.neno>
Date: Tue, 5 Jan 2010 18:07:35 +0200
Message-ID: <cc557aab1001050807t58d2fd8dg57e4f3c1883e6824@mail.gmail.com>
From: "Kirill A. Shutemov" <kirill@shutemov.name>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH 09/15] usb-linux.c: fix warning with
	_FORTIFY_SOURCE
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@trasno.org>
Cc: qemu-devel@nongnu.org

On Tue, Jan 5, 2010 at 4:42 PM, Juan Quintela <quintela@trasno.org> wrote:
> "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
>> =C2=A0 CC =C2=A0 =C2=A0usb-linux.o
>> cc1: warnings being treated as errors
>> usb-linux.c: In function 'usb_host_read_file':
>> usb-linux.c:1204: error: ignoring return value of 'fgets', declared with=
 attribute warn_unused_result
>> make: *** [usb-linux.o] Error 1
>>
>> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
>> ---
>> =C2=A0usb-linux.c | =C2=A0 =C2=A08 ++++++--
>> =C2=A01 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/usb-linux.c b/usb-linux.c
>> index 88728e9..8673474 100644
>> --- a/usb-linux.c
>> +++ b/usb-linux.c
>> @@ -1201,9 +1201,13 @@ static int usb_host_read_file(char *line, size_t =
line_size, const char *device_f
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 device_file);
>> =C2=A0 =C2=A0 =C2=A0f =3D fopen(filename, "r");
>> =C2=A0 =C2=A0 =C2=A0if (f) {
>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0fgets(line, line_size, f);
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0if (fgets(line, line_size, f)) {
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D 1;
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0} else {
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D 0;
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0}
>> +
> This if is equivalent to:
>
> ret =3D !!fgets(line, line_size, f);
>
> No need for the if at all :)

It's not very readable.
Probably better to use something like:

ret =3D (fgets(line, line_size, f) !=3D NULL);