Re: [PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests

[Pierre Morel <pmorel@linux.ibm.com>]

On 2019-11-15 15:22, Thomas Huth wrote:
> On 14/11/2019 18.17, Pierre Morel wrote:
>> On 2019-11-14 13:33, Thomas Huth wrote:
>>> On 14/11/2019 11.38, Cornelia Huck wrote:
>>>> On Wed, 13 Nov 2019 20:02:33 +0100
>>>> Pierre Morel <pmorel@linux.ibm.com> wrote:
>>>>
>>>> Minor nit for $SUBJECT: this isn't a kvm-unit-tests patch, that's just
>>>> one consumer :)
>>>>
>>>>> The PONG device accept two commands: PONG_READ and PONG_WRITE
>>>>> which allow to read from and write to an internal buffer of
>>>>> 1024 bytes.
>>>>>
>>>>> The QEMU device is named ccw-pong.
>>>>>
>>>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>>>>> ---
>>>>>    hw/s390x/Makefile.objs  |   1 +
>>>>>    hw/s390x/ccw-pong.c     | 186
>>>>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>>>>    include/hw/s390x/pong.h |  47 ++++++++++++
>>>>>    3 files changed, 234 insertions(+)
>>>>>    create mode 100644 hw/s390x/ccw-pong.c
>>>>>    create mode 100644 include/hw/s390x/pong.h
>>>>>
>>>>> diff --git a/hw/s390x/Makefile.objs b/hw/s390x/Makefile.objs
>>>>> index ee91152..3a83438 100644
>>>>> --- a/hw/s390x/Makefile.objs
>>>>> +++ b/hw/s390x/Makefile.objs
>>>>> @@ -32,6 +32,7 @@ obj-$(CONFIG_KVM) += tod-kvm.o
>>>>>    obj-$(CONFIG_KVM) += s390-skeys-kvm.o
>>>>>    obj-$(CONFIG_KVM) += s390-stattrib-kvm.o s390-mchk.o
>>>>>    obj-y += s390-ccw.o
>>>>> +obj-y += ccw-pong.o
>>>> Not sure if unconditionally introducing a test device is a good idea.
>>> This definitely needs a CONFIG switch (which can be "y" by default, but
>>> still we should provide a possibility to disable it)
>> yes, clearly
> I just noticed that we already have a global config switch for such
> devices, so you could simply do:
>
> obj-$(CONFIG_TEST_DEVICE) += ccw-pong.o
>
>   Thomas


Thanks, will do! :)

regards,

Pierre


-- 
Pierre Morel
IBM Lab Boeblingen