From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Eric Blake <eblake@redhat.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, qemu-devel@nongnu.org,
mreitz@redhat.com
Subject: Re: [PATCH 3/3] block/nbd: nbd_co_reconnect_loop(): don't sleep if drained
Date: Mon, 27 Jul 2020 21:42:47 +0300 [thread overview]
Message-ID: <cc6a586a-e84c-fd6c-3b09-c71ea3da4ece@virtuozzo.com> (raw)
In-Reply-To: <a4a5d4a2-eb71-ea87-efce-28734b6d4116@redhat.com>
23.07.2020 21:55, Eric Blake wrote:
> On 7/20/20 4:00 AM, Vladimir Sementsov-Ogievskiy wrote:
>> We try to go to wakeable sleep, so that, if drain begins it will break
>> the sleep. But what if nbd_client_co_drain_begin() already called and
>> s->drained is already true? We'll go to sleep, and drain will have to
>> wait for the whole timeout. Let's improve it.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>> block/nbd.c | 11 ++++++-----
>> 1 file changed, 6 insertions(+), 5 deletions(-)
>>
>
> How frequently did you hit this case? At any rate, the optimization looks sane, and I'm happy to include it in 5.1.
>
I don't remember. Probably once? And, as I said in cover letter, it even was not master branch but some my experiment..
--
Best regards,
Vladimir
prev parent reply other threads:[~2020-07-27 18:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 9:00 [PATCH for-5.1? 0/3] Fix nbd reconnect dead-locks Vladimir Sementsov-Ogievskiy
2020-07-20 9:00 ` [PATCH 1/3] block/nbd: allow drain during reconnect attempt Vladimir Sementsov-Ogievskiy
2020-07-20 9:02 ` Vladimir Sementsov-Ogievskiy
2020-07-23 18:47 ` Eric Blake
2020-07-24 10:04 ` Vladimir Sementsov-Ogievskiy
2020-07-24 11:50 ` Vladimir Sementsov-Ogievskiy
2020-07-24 9:49 ` Vladimir Sementsov-Ogievskiy
2020-07-24 10:21 ` Vladimir Sementsov-Ogievskiy
2020-07-20 9:00 ` [PATCH 2/3] block/nbd: on shutdown terminate connection attempt Vladimir Sementsov-Ogievskiy
2020-07-23 18:52 ` Eric Blake
2020-07-20 9:00 ` [PATCH 3/3] block/nbd: nbd_co_reconnect_loop(): don't sleep if drained Vladimir Sementsov-Ogievskiy
2020-07-23 18:55 ` Eric Blake
2020-07-27 18:42 ` Vladimir Sementsov-Ogievskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc6a586a-e84c-fd6c-3b09-c71ea3da4ece@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).