From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D8C3C433F5 for ; Fri, 19 Nov 2021 09:30:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D045C60EE0 for ; Fri, 19 Nov 2021 09:30:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D045C60EE0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:59490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mo0Df-00088A-P4 for qemu-devel@archiver.kernel.org; Fri, 19 Nov 2021 04:30:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo0Bl-0004mE-Gu for qemu-devel@nongnu.org; Fri, 19 Nov 2021 04:28:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56539) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo0Bj-0007KF-QB for qemu-devel@nongnu.org; Fri, 19 Nov 2021 04:28:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637314087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GKy5ZaJu1nfCFu8FDsXuYuIHwY4f7uM8rNjfYzVBDWY=; b=WDFRz0Ir7UnIh9SVzgED/fdv8sLhNguzp5W0okF3Qfsnq7YiLHGV9EAoE/DiVIk8k54QA3 la+/1G8/JpPJA6831X5oAip2lYZyqyjJ5+2VnmDiU1bRyroPIRQpbB+Gzehs21aISofFjU KHFpNvQp/uXculJjP/xL9U8ql8eLKnc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-34-ZdhTrk02NcmjffjAHQ1-ag-1; Fri, 19 Nov 2021 04:28:03 -0500 X-MC-Unique: ZdhTrk02NcmjffjAHQ1-ag-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CFD521023F4D; Fri, 19 Nov 2021 09:28:02 +0000 (UTC) Received: from [10.39.194.192] (unknown [10.39.194.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 08D3B19D9B; Fri, 19 Nov 2021 09:27:58 +0000 (UTC) Message-ID: Date: Fri, 19 Nov 2021 10:27:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: Chardev: delete the QemuOpts reserved in vm_config_groups To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , =?UTF-8?B?44G36aOO6L+H5peg55eVPz8=?= <787738581@qq.com> References: From: Paolo Bonzini In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -51 X-Spam_score: -5.2 X-Spam_bar: ----- X-Spam_report: (-5.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.727, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/8/21 09:46, Marc-André Lureau wrote: >> + QemuOpts *opts; >> >> chr = qemu_chr_find(id); >> if (chr == NULL) { >> @@ -1175,6 +1177,10 @@ void qmp_chardev_remove(const char *id, Error **errp) >> return; >> } >> object_unparent(OBJECT(chr)); >> + /* delete the opts reserved in vm_config_groups list. */ >> + opts = qemu_opts_find(qemu_find_opts("chardev"), id); >> + if (opts) >> + qemu_opts_del(opts); > That seems reasonable to me, > Reviewed-by: Marc-André Lureau I think it should be done instead in an unparent function, i.e. with something like "oc->unparent = chr_unparent;" in char_class_init. chr_unparent does the qemu_opts_find/qemu_opts_del. Thanks, Paolo